Page MenuHomePhabricator
Differential D18480

[chronik] Python client: add support for paths in host
ClosedPublic
Actions

Authored by Fabien on Aug 12 2025, 10:38.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABCfd9ec11f3940: [chronik] Python client: add support for paths in host
Summary

So we can support hosts that look like so: https://chronik.foo/xec

We don't use that in tests but it is useful for external scripts relying on this library.

Test Plan

Use it to connect to the public chronik.pay2stay.com/xec

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik_support_client_slash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34125
Build 67719: Build Diffbuild-without-wallet · build-diff · build-clang · build-clang-tidy · build-debug
Build 67718: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 12 2025, 10:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2025, 10:38
Fabien requested review of this revision.Aug 12 2025, 10:38
tobias_ruck requested changes to this revision.Aug 12 2025, 10:45
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
test/functional/test_framework/chronik/client.py
310–312 ↗(On Diff #55204)

usually this is called "path", not prefix; maybe path_prefix? but if you think this is pretty unambiguous already we can keep prefix

332 ↗(On Diff #55204)

how about just having this be the empty string if no prefix/path? then just just a concatenation

This revision now requires changes to proceed.Aug 12 2025, 10:45
Harbormaster completed remote builds in B34124: Diff 55204.Aug 12 2025, 10:58
Fabien updated this revision to Diff 55205.Aug 12 2025, 11:03

Simplify after feedback

Harbormaster completed remote builds in B34125: Diff 55205.Aug 12 2025, 11:17
tobias_ruck accepted this revision.Aug 12 2025, 13:27

added a suggestion, but no blocker

test/functional/test_framework/chronik/client.py
189–191

i think this would be cleaner

This revision is now accepted and ready to land.Aug 12 2025, 13:27
Closed by commit rABCfd9ec11f3940: [chronik] Python client: add support for paths in host (authored by Fabien). · Explain WhyAug 12 2025, 15:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfd9ec11f3940: [chronik] Python client: add support for paths in host.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
chronik/
9 lines

Diff 55205

View Options

test/functional/test_framework/chronik/client.py

Loading...