Clarify prevector::erase and avoid swap-to-clear
ClosedPublic
Actions

Authored by deadalnix on Oct 1 2018, 11:39.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING779f9d7d010f: Clarify prevector::erase and avoid swap-to-clear
rABC779f9d7d010f: Clarify prevector::erase and avoid swap-to-clear

Summary

This is a backport of Core PR10534

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

prevectornoswap

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3466
Build 5008: Bitcoin ABC Buildbot (legacy)
Build 5007: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 1 2018, 11:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2018, 11:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3466: Diff 5205.Oct 1 2018, 11:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Oct 2 2018, 01:07

This revision is now accepted and ready to land.Oct 2 2018, 01:07

Closed by commit rABC779f9d7d010f: Clarify prevector::erase and avoid swap-to-clear (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyOct 2 2018, 09:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

prevector.h

6 lines

script/

script.h

5 lines

Diff 5205

View Options

src/prevector.h