[ecash-wallet] Support including arbitrary data with ALP txs
ClosedPublic
Actions

Authored by bytesofman on Sep 9 2025, 18:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC420e38e8e6f3: [ecash-wallet] Support including arbitrary data with ALP txs

Summary

ALP txs may include arbitary information in addition to the token tx itself. Support this with the already-defined DataAction.

Test Plan

npm test, CI integration test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ew-alp-data-support

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34366
Build 68200: Build Diff	ecash-wallet-tests · cashtab-faucet-tests · ecash-wallet-integration-tests
Build 68199: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 9 2025, 18:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2025, 18:47

add some more tests to confirm expected behavior

Harbormaster completed remote builds in B34365: Diff 55541.Sep 9 2025, 18:57

Build Bitcoin ABC Diffs / Diff Testing (ecash-wallet-integration-tests) failed.

Failed tests logs:

====== Wallet can build and broadcast on regtest: We can send an ALP tx with DataAction containing "test" (ASCII encoded).Wallet can build and broadcast on regtest We can send an ALP tx with DataAction containing "test" (ASCII encoded) ======
AssertionError: expected '6a5037534c5032000453454e442c05c483f40…' to equal '6a5037534c5032000453454e44ae4d564a296…'
    at Context.<anonymous> (test/transactions.test.ts:2090:29)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

      + expected - actual

      -6a5037534c5032000453454e442c05c483f40895f9effbd55d584042fb94b06a785fb96602d097eebffaaa8e54026400000000008403000000000474657374
      +6a5037534c5032000453454e44ae4d564a2968d3c11bfd7e349f3180cedecc39d4eb7f1d6cf581d7570a6d0566026400000000008403000000000474657374

Each failure log is accessible here:
Wallet can build and broadcast on regtest: We can send an ALP tx with DataAction containing "test" (ASCII encoded).Wallet can build and broadcast on regtest We can send an ALP tx with DataAction containing "test" (ASCII encoded)

Harbormaster completed remote builds in B34366: Diff 55542.Sep 9 2025, 19:03

bytesofman published this revision for review.Sep 9 2025, 19:06

Fabien accepted this revision.Sep 9 2025, 20:19

This revision is now accepted and ready to land.Sep 9 2025, 20:19

Closed by commit rABC420e38e8e6f3: [ecash-wallet] Support including arbitrary data with ALP txs (authored by bytesofman). · Explain WhySep 9 2025, 20:24

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC420e38e8e6f3: [ecash-wallet] Support including arbitrary data with ALP txs.