[tests] Update Unit Test for addrman.h/addrman.cpp
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2018, 12:12.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING444c2e51ede0: [tests] Update Unit Test for addrman.h/addrman.cpp
rABC444c2e51ede0: [tests] Update Unit Test for addrman.h/addrman.cpp

Summary

Add test for adding multiple addresses to address manager
Clean up unnecessary modulo operations
Add test for GetNewBucket's alternate method signature

This is a backport of Core PR10287

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

updatetest

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3479
Build 5034: Bitcoin ABC Buildbot (legacy)
Build 5033: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2018, 12:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2018, 12:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1862: Add test-before-evict discipline to addrman.Oct 2 2018, 12:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3479: Diff 5225.Oct 2 2018, 12:29

jasonbcox requested changes to this revision.Oct 3 2018, 04:35

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/addrman_tests.cpp
396	How did this value change, yet the test still passes? I don't see any logic changes.

This revision now requires changes to proceed.Oct 3 2018, 04:35

deadalnix requested review of this revision.Oct 3 2018, 11:47

deadalnix marked an inline comment as done.

deadalnix added inline comments.

src/test/addrman_tests.cpp
396	The number of collision is different because the loop above changed.

jasonbcox accepted this revision.Oct 4 2018, 19:03

jasonbcox added inline comments.

src/test/addrman_tests.cpp
396	Ah got it

This revision is now accepted and ready to land.Oct 4 2018, 19:03

Closed by commit rABC444c2e51ede0: [tests] Update Unit Test for addrman.h/addrman.cpp (authored by Jimmy Song <jaejoon@gmail.com>, committed by deadalnix). · Explain WhyOct 4 2018, 21:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

addrman_tests.cpp

31 lines

Diff 5225

View Options

src/test/addrman_tests.cpp

[tests] Update Unit Test for addrman.h/addrman.cppClosedPublicActions