Differential D1868

[qa] fundrawtransaction to use billable_size instead of count_bytes
ClosedPublic
Actions

Authored by schancel on Oct 3 2018, 05:09.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfe6305d6b499: [qa] fundrawtransaction to use billable_size instead of count_bytes
rABCfe6305d6b499: [qa] fundrawtransaction to use billable_size instead of count_bytes

Summary

Replace count_bytes for billable_size to properly calculate resultant_fee_rate
when billable_size actually changes from being the transaction size.

Depends on D1645

Test Plan

./test/functional/test_runner.py fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Oct 3 2018, 05:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2018, 05:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3488: Diff 5236.Oct 3 2018, 05:29

deadalnix accepted this revision.Oct 3 2018, 11:32

This revision is now accepted and ready to land.Oct 3 2018, 11:32

Closed by commit rABCfe6305d6b499: [qa] fundrawtransaction to use billable_size instead of count_bytes (authored by schancel). · Explain WhyOct 4 2018, 03:20

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

fundrawtransaction.py

3 lines

Diff 5258

test/functional/fundrawtransaction.py

Loading...