netbase: Do not print an error on connection timeouts through proxy
ClosedPublic
Actions

Authored by deadalnix on Oct 3 2018, 15:24.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING435429be9447: netbase: Do not print an error on connection timeouts through proxy
rABC435429be9447: netbase: Do not print an error on connection timeouts through proxy

Summary

netbase: Make InterruptibleRecv return an error code instead of bool

netbase: Do not print an error on connection timeouts through proxy

If a timeout happens while reading the proxy response, this effectively
means we timed out while connecting to the remote node. This is very
common for Tor, so do not print an error message.

This is a backport of Core PR9726

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 3 2018, 15:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2018, 15:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1873: net: Improve and document SOCKS code.Oct 3 2018, 15:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3495: Diff 5249.Oct 3 2018, 15:41

jasonbcox accepted this revision.Oct 3 2018, 19:58

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/netbase.cpp
183 ↗	(On Diff #5249)	I understand this is a backport, but what an awful class name...

This revision is now accepted and ready to land.Oct 3 2018, 19:58

deadalnix marked an inline comment as done.Oct 4 2018, 09:29

deadalnix added inline comments.

src/netbase.cpp
183 ↗	(On Diff #5249)	`class AwflClsNm`

Closed by commit rABC435429be9447: netbase: Do not print an error on connection timeouts through proxy (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyOct 4 2018, 09:31

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

netbase.cpp

63 lines

Diff 5262

View Options

netbase: Do not print an error on connection timeouts through proxyClosedPublicActions