Differential D18768

[faucet] Convert amounts from bigint to number for json serialization
ClosedPublic
Actions

Authored by Fabien on Oct 8 2025, 09:07.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCdc715f252d63: [faucet] Convert amounts from bigint to number for json serialization

Summary

The amount is guaranteed to fit into a Number and the json serialization don't know how to serialize a BigInt by default.

Test Plan

Trivial

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_testnet_faucet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34733
Build 68930: Build Diff
Build 68929: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 8 2025, 09:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2025, 09:07

Fabien requested review of this revision.Oct 8 2025, 09:07

Harbormaster completed remote builds in B34733: Diff 56097.Oct 8 2025, 09:07

PiRK accepted this revision.Oct 8 2025, 09:50

This revision is now accepted and ready to land.Oct 8 2025, 09:50

Closed by commit rABCdc715f252d63: [faucet] Convert amounts from bigint to number for json serialization (authored by Fabien). · Explain WhyOct 8 2025, 09:57

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdc715f252d63: [faucet] Convert amounts from bigint to number for json serialization.

Revision Contents
Changeset List

Path

Size

apps/

faucet/

index.ts

4 lines

Diff 56097

View Options

[faucet] Convert amounts from bigint to number for json serializationClosedPublicActions