We have the case of a staker splitting the coins into several proofs and using the same payout address, making it impossible to differentiate. This makes the staked amount wrong as the code currently stops on first payout match, as well as the expected gain.
Fix this by summing all the identical payout addresses accross stakers. The test data is massaged to cover the change.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC89f8d0777398: [herald] Fix a bug in the staked amount when there are multiple proofs for the…
npm run test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- herald_staker_amount_bug
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 34777 Build 69016: Build Diff ecash-herald-tests Build 69015: arc lint + arc unit