Page MenuHomePhabricator
Differential D18798

[e.cash] Properly use constants for the URLs
ClosedPublic
Actions

Authored by Fabien on Oct 16 2025, 09:17.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCfbbb6ee2368f: [e.cash] Properly use constants for the URLs
Summary

Consistently use the constants:

  • NEXT_PUBLIC_SITE_URL for the main URL
  • NEXT_PUBLIC_STRAPI_URL for the strapi URL
  • NEXT_PUBLIC_STRAPI_SCORECARD_URL for the scorecard URL

Ref T3904.

Test Plan
npm run dev

Check the site works as normal

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash_properly_use_constants_url
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34795
Build 69052: Build Diff
Build 69051: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 16 2025, 09:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2025, 09:17
Fabien requested review of this revision.Oct 16 2025, 09:17
Harbormaster completed remote builds in B34794: Diff 56190.Oct 16 2025, 09:17
Fabien edited the summary of this revision. (Show Details)Oct 16 2025, 09:21
Fabien edited the summary of this revision. (Show Details)
Fabien added a task: Restricted Maniphest Task.
Fabien planned changes to this revision.Oct 16 2025, 09:24
Fabien updated this revision to Diff 56191.Oct 16 2025, 09:29

Fix README and FAQ

Harbormaster completed remote builds in B34795: Diff 56191.Oct 16 2025, 09:29
Fabien added a child revision: D18799: [e.cash] Update the strapi URL.Oct 16 2025, 09:32
PiRK accepted this revision.Oct 16 2025, 15:29
This revision is now accepted and ready to land.Oct 16 2025, 15:29
Closed by commit rABCfbbb6ee2368f: [e.cash] Properly use constants for the URLs (authored by Fabien). · Explain WhyOct 17 2025, 08:21
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfbbb6ee2368f: [e.cash] Properly use constants for the URLs.

Revision Contents
Changeset List

PathSize
web/
e.cash/
13 lines
app/
blog/
[slug]/
6 lines
components/
Blog/
2 lines
13 lines
Home/
2 lines
data/
9 lines
3 lines
2 lines
4 lines
14 lines
14 lines

Diff 56191

View Options

web/e.cash/README.md

Loading...
View Options

web/e.cash/app/blog/[slug]/page.tsx

Loading...
View Options

web/e.cash/app/components/Blog/BlogRecommendation.tsx

Loading...
View Options

web/e.cash/app/components/Blog/BlogSearch.tsx

Loading...
View Options

web/e.cash/app/components/Home/FeaturedArticlesClient.tsx

Loading...
View Options

web/e.cash/app/data/blog.ts

Loading...
View Options

web/e.cash/app/data/faqs.ts

Loading...
View Options

web/e.cash/app/data/products.ts

Loading...
View Options

web/e.cash/app/layout.tsx

Loading...
View Options

web/e.cash/next.config.ts

Loading...
View Options

web/e.cash/next.preview.ts

Loading...