Page MenuHomePhabricator
Differential D18807

coins, refactor: Make AddFlags, SetDirty, SetFresh static
ClosedPublic
Actions

Authored by PiRK on Oct 20 2025, 14:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC85094becdd96: coins, refactor: Make AddFlags, SetDirty, SetFresh static
Summary

This makes the Assume(&self.second == this) check redundant

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>

This is a partial backport of core#30906
https://github.com/bitcoin/bitcoin/pull/30906/commits/fc8c282022e6ce4eb3ce526800a6ada3b4a2996d

Depends on D18806

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Oct 20 2025, 14:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2025, 14:07
PiRK requested review of this revision.Oct 20 2025, 14:07
teamcity edited the summary of this revision. (Show Details)Oct 20 2025, 14:07
PiRK added a child revision: D18808: coins, refactor: Assume state after SetClean in AddFlags to prevent dangling pointers.Oct 20 2025, 14:09
Harbormaster completed remote builds in B34819: Diff 56224.Oct 20 2025, 14:11
teamcity added a comment.Oct 20 2025, 14:11
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 20 2025, 14:15
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 20 2025, 14:18
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 56238.Oct 20 2025, 16:32

rebase

Harbormaster completed remote builds in B34829: Diff 56238.Oct 20 2025, 16:49
Fabien accepted this revision.Oct 21 2025, 07:12
This revision is now accepted and ready to land.Oct 21 2025, 07:12
Closed by commit rABC85094becdd96: coins, refactor: Make AddFlags, SetDirty, SetFresh static (authored by Lőrinc <pap.lorinc@gmail.com>, committed by PiRK). · Explain WhyOct 21 2025, 12:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC85094becdd96: coins, refactor: Make AddFlags, SetDirty, SetFresh static.

Revision Contents
Changeset List

PathSize
src/
19 lines

Diff 56238

View Options

src/coins.h

Loading...