Page MenuHomePhabricator
Differential D1880

Update ban-state in case of dirty-state during periodic sweep
ClosedPublic
Actions

Authored by deadalnix on Oct 5 2018, 09:57.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING6bdecf64dfd3: Update ban-state in case of dirty-state during periodic sweep
rABC6bdecf64dfd3: Update ban-state in case of dirty-state during periodic sweep
Summary

Ensure the UI is updated when we update the banlist by calling it ouside of the cs_setBanned lock.

This is a backport of Core PR11616

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bannedlistchanged
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3515
Build 5106: Bitcoin ABC Buildbot (legacy)
Build 5105: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 5 2018, 09:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 09:57
teamcity added a subscriber: teamcity.Oct 5 2018, 09:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 5 2018, 10:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3515: Diff 5282.Oct 5 2018, 10:15
schancel accepted this revision.Oct 5 2018, 22:18
schancel added a subscriber: schancel.

Commit comment makes it sound as though notification was happening before, and need to be moved out of a critical area. That is not the case.

This revision is now accepted and ready to land.Oct 5 2018, 22:18
schancel edited the summary of this revision. (Show Details)Oct 5 2018, 22:19
Closed by commit rABC6bdecf64dfd3: Update ban-state in case of dirty-state during periodic sweep (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by deadalnix). · Explain WhyOct 6 2018, 09:55
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
37 lines

Diff 5282

View Options

src/net.cpp

Loading...