Paths

Table of Contentst

Differential D18818

Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64
ClosedPublic
Actions

Authored by PiRK on Wed, Oct 22, 09:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC894eed691fed: Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64

Summary

This is a partial backport of core#26153
https://github.com/bitcoin/bitcoin/pull/26153/commits/6babf402130a8f3ef3058594750aeaa50b8f5044
Depends on D18817

Test Plan

ninja all check-all bench-bitcoin bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Oct 22, 09:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 22, 09:43

PiRK requested review of this revision.Wed, Oct 22, 09:43

teamcity edited the summary of this revision. (Show Details)Wed, Oct 22, 09:43

PiRK added a child revision: D18819: Make unrestricted ChaCha20 cipher not waste keystream bytes.Wed, Oct 22, 09:44

Harbormaster completed remote builds in B34842: Diff 56258.Wed, Oct 22, 10:04

Fabien accepted this revision.Thu, Oct 23, 12:51

This revision is now accepted and ready to land.Thu, Oct 23, 12:51

Closed by commit rABC894eed691fed: Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64 (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyThu, Oct 23, 17:41

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC894eed691fed: Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64.

Revision Contents
Changeset List

Path

Size

src/

bench/

chacha20.cpp

2 lines

crypto/

chacha20.h

4 lines

chacha20.cpp

2 lines

chacha_poly_aead.cpp

8 lines

test/

crypto_tests.cpp

8 lines

fuzz/

crypto_chacha20.cpp

3 lines

Diff 56273

View Options

src/bench/chacha20.cpp

View Options

src/crypto/chacha20.h

View Options

src/crypto/chacha20.cpp

View Options

src/crypto/chacha_poly_aead.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/fuzz/crypto_chacha20.cpp

Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56273

src/bench/chacha20.cpp

src/crypto/chacha20.h

src/crypto/chacha20.cpp

src/crypto/chacha_poly_aead.cpp

src/test/crypto_tests.cpp

src/test/fuzz/crypto_chacha20.cpp

Rename ChaCha20::Seek -> Seek64 to clarify multiple of 64
ClosedPublic
Actions

Revision Contents
Changeset List