Page MenuHomePhabricator
Differential D18825

Inline ChaCha20 32-byte specific constants
ClosedPublic
Actions

Authored by PiRK on Wed, Oct 22, 09:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2286be3a8762: Inline ChaCha20 32-byte specific constants
Summary

This is a partial backport of core#26153
https://github.com/bitcoin/bitcoin/pull/26153/commits/93aee8bbdad808b7009279b67470d496cc26b936

Depends on D18825

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Oct 22, 09:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 22, 09:54
PiRK requested review of this revision.Wed, Oct 22, 09:54
teamcity edited the summary of this revision. (Show Details)Wed, Oct 22, 09:54
PiRK added a child revision: D18826: Improve test vectors for ChaCha20.Wed, Oct 22, 09:55
Harbormaster completed remote builds in B34849: Diff 56265.Wed, Oct 22, 10:54
Fabien accepted this revision.Thu, Oct 23, 13:14
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/crypto/chacha20.cpp
100 ↗(On Diff #56265)

Nice

This revision is now accepted and ready to land.Thu, Oct 23, 13:14
Closed by commit rABC2286be3a8762: Inline ChaCha20 32-byte specific constants (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyThu, Oct 23, 17:41
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2286be3a8762: Inline ChaCha20 32-byte specific constants.

Revision Contents
Changeset List

PathSize
src/
crypto/
2 lines
140 lines

Diff 56281

View Options

src/crypto/chacha20.h

Loading...
View Options

src/crypto/chacha20.cpp

Loading...