Page MenuHomePhabricator
Differential D18848

script: (refactor) prepare for introducing sighash midstate cache
ClosedPublic
Actions

Authored by PiRK on Wed, Oct 29, 09:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8f7582f2e39e: script: (refactor) prepare for introducing sighash midstate cache
Summary

This is a partial backport of core#32473
https://github.com/bitcoin/bitcoin/pull/32473/commits/8f3ddb0bccebc930836b4a6745a7cf29b41eb302

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Oct 29, 09:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 29, 09:33
PiRK requested review of this revision.Wed, Oct 29, 09:33
teamcity edited the summary of this revision. (Show Details)Wed, Oct 29, 09:33
PiRK added a child revision: D18849: script: (optimization) introduce sighash midstate caching.Wed, Oct 29, 09:42
Harbormaster completed remote builds in B34899: Diff 56345.Wed, Oct 29, 09:53
Fabien accepted this revision.Thu, Oct 30, 08:52
This revision is now accepted and ready to land.Thu, Oct 30, 08:52
Fabien requested changes to this revision.Thu, Oct 30, 09:30
This revision now requires changes to proceed.Thu, Oct 30, 09:30
Fabien added inline comments.Thu, Oct 30, 09:33
src/script/interpreter.cpp
1553 ↗(On Diff #56345)

This is actually a change in behavior and no longer a refactor

PiRK updated this revision to Diff 56362.Thu, Oct 30, 12:27

rebase on D18851 (test coverage for previous change in behavior) and fix the problem

Harbormaster completed remote builds in B34911: Diff 56362.Thu, Oct 30, 12:49
Fabien accepted this revision.Thu, Oct 30, 20:51
This revision is now accepted and ready to land.Thu, Oct 30, 20:51
Closed by commit rABC8f7582f2e39e: script: (refactor) prepare for introducing sighash midstate cache (authored by PiRK). · Explain WhyFri, Oct 31, 09:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8f7582f2e39e: script: (refactor) prepare for introducing sighash midstate cache.

Revision Contents
Changeset List

PathSize
src/
script/
49 lines

Diff 56371

View Options

src/script/interpreter.cpp

Loading...