Pretty sure the issue is this

• docker file installs ecash-lib from online
• but at this point, it still has ecash-wallet as a local dep, and the local-dep ecash-wallet has ecash-lib as a local dep
• so ecash-lib conflicts and we get an error

to keep all the deps for the published version the published deps, we need to do first replace all the local deps with published deps, then npm install

I don't get it, you can use the npmjs dependencies but still use npm ci to stick to pinned versions ? Otherwise you can't know what your dependency chain is. Our own dependencies are fine, we manage them but third party ones need to be pinned

we have to update the package-lock.json in this dockerfile somewhere in order to use the published deps; this was already happening in the old version as running npm install ecash-lib also updates the whole package-lock.json; then we were just calling npm ci after that on the updated package-lock.json

The pinned versions in package.json would ensure those deps remained the same, but their transitive deps could have been changing before this diff (tho there are none in this lib, so moot point)

so, we could also call npm ci again after our npm install here ... but there is not really a benefit to doing this, we've already installed what generated the package-lock.json in this docker container.

More to the point for this diff though -- ecash-agora has no dependencies except for ecash-lib, chronik-client, and ecash-wallet

The other stuff in the package.json is just dev dependencies which are not included in the published package; this was the original problem that triggered the need for this change: ecash-wallet was a dev dep so it wasn't getting into the published package (which now actually uses it in published methods), causing errors in apps installing the latest versions.