Page MenuHomePhabricator
Differential D18859

Expose CSignatureCache class in header
ClosedPublic
Actions

Authored by PiRK on Fri, Oct 31, 15:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2a0800e3e55b: Expose CSignatureCache class in header
Summary

This is done in preparation for the following commit. Also rename it to
SignatureCache.

This is a partial backport of core#30141
https://github.com/bitcoin/bitcoin/pull/30141/commits/66d74bfc45ae0f743084475ac3bbfb4355bb6ec2
Depends on D18858

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Oct 31, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Oct 31, 15:07
teamcity edited the summary of this revision. (Show Details)Fri, Oct 31, 15:07
PiRK added a child revision: D18860: kernel: De-globalize signature cache.Fri, Oct 31, 15:15
Harbormaster completed remote builds in B34925: Diff 56382.Fri, Oct 31, 15:26
teamcity added a comment.Fri, Oct 31, 15:27
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

PASSED                [ 80%]##teamcity[testFinished timestamp='2025-10-31T15:25:56.331' duration='49' flowId='tests.test_iguana.test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']

tests/test_iguana.py::test_redeem_script_empty_stack ##teamcity[testStarted timestamp='2025-10-31T15:25:56.332' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_empty_stack' metainfo='test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']
PASSED              [ 85%]##teamcity[testFinished timestamp='2025-10-31T15:25:56.354' duration='21' flowId='tests.test_iguana.test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']

tests/test_iguana.py::test_redeem_script_false ##teamcity[testStarted timestamp='2025-10-31T15:25:56.355' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_false' metainfo='test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']
PASSED                    [ 90%]##teamcity[testFinished timestamp='2025-10-31T15:25:56.378' duration='22' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']

tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2025-10-31T15:25:56.379' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']
PASSED               [ 95%]##teamcity[testFinished timestamp='2025-10-31T15:25:56.418' duration='38' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']

tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2025-10-31T15:25:56.419' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']
PASSED          [100%]##teamcity[testFinished timestamp='2025-10-31T15:25:56.465' duration='45' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']


============================== 20 passed in 0.88s ==============================
[222/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[223/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[224/540] Test Bitcoin utilities...
[225/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[226/540] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/fixture.cpp.o
[227/540] Linking CXX executable src/pow/test/test-pow
[228/540] pow: testing daa_tests
[229/540] Running utility command for check-pow-daa_tests
[230/540] pow: testing eda_tests
[231/540] Running utility command for check-pow-eda_tests
[232/540] pow: testing grasberg_tests
[233/540] Running utility command for check-pow-grasberg_tests
[234/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[235/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[236/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[237/540] pow: testing aserti32d_tests
[238/540] Running utility command for check-pow-aserti32d_tests
[239/540] Running pow test suite
PASSED: pow test suite
[240/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[241/540] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o
[242/540] Linking CXX executable src/seeder/test/test-seeder
[243/540] seeder: testing message_writer_tests
[244/540] seeder: testing db_tests
[245/540] seeder: testing options_tests
[246/540] seeder: testing p2p_messaging_tests
[247/540] seeder: testing parse_name_tests
[248/540] seeder: testing write_name_tests
[249/540] Running utility command for check-seeder-options_tests
[250/540] Running utility command for check-seeder-p2p_messaging_tests
[251/540] Running utility command for check-seeder-message_writer_tests
[252/540] Running utility command for check-seeder-db_tests
[253/540] Running utility command for check-seeder-write_name_tests
[254/540] Running utility command for check-seeder-parse_name_tests
[255/540] Running seeder test suite
PASSED: seeder test suite
[256/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[257/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[258/540] Linking CXX executable src/qt/test/test_bitcoin-qt
[259/540] bitcoin-qt: testing test_bitcoin-qt
[260/540] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Fri, Oct 31, 15:27
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "kernel/chainstatemanager_opts -> script/scriptcache -> validation -> kernel/chainstatemanager_opts" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
teamcity added a comment.Fri, Oct 31, 15:32
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

============================== 20 passed in 0.70s ==============================
[207/545] Automatic MOC for target test_bitcoin-qt
[208/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[209/545] Test Bitcoin utilities...
[210/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[211/545] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/__/chronik/test/bridgeprimitives_tests.cpp.o
[212/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/eda_tests.cpp.o
[213/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[214/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/daa_tests.cpp.o
[215/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/aserti32d_tests.cpp.o
[216/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/grasberg_tests.cpp.o
[217/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[218/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[219/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[220/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[221/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/fixture.cpp.o
[222/545] Linking CXX executable src/pow/test/test-pow
[223/545] pow: testing daa_tests
[224/545] Running utility command for check-pow-daa_tests
[225/545] pow: testing eda_tests
[226/545] Running utility command for check-pow-eda_tests
[227/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[228/545] pow: testing grasberg_tests
[229/545] Running utility command for check-pow-grasberg_tests
[230/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[231/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[232/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o
[233/545] Linking CXX executable src/seeder/test/test-seeder
[234/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[235/545] seeder: testing message_writer_tests
[236/545] seeder: testing options_tests
[237/545] seeder: testing parse_name_tests
[238/545] seeder: testing db_tests
[239/545] seeder: testing p2p_messaging_tests
[240/545] Running utility command for check-seeder-message_writer_tests
[241/545] seeder: testing write_name_tests
[242/545] Running utility command for check-seeder-options_tests
[243/545] Running utility command for check-seeder-db_tests
[244/545] Running utility command for check-seeder-parse_name_tests
[245/545] Running utility command for check-seeder-p2p_messaging_tests
[246/545] Running utility command for check-seeder-write_name_tests
[247/545] Running seeder test suite
PASSED: seeder test suite
[248/545] pow: testing aserti32d_tests
[249/545] Running utility command for check-pow-aserti32d_tests
[250/545] Running pow test suite
PASSED: pow test suite
[251/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[252/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[253/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[254/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[255/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[256/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[257/545] Linking CXX executable src/qt/test/test_bitcoin-qt
[258/545] bitcoin-qt: testing test_bitcoin-qt
[259/545] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 56388.Fri, Oct 31, 15:52

rebase

PiRK published this revision for review.Fri, Oct 31, 16:09
Harbormaster completed remote builds in B34930: Diff 56388.Fri, Oct 31, 16:13
Fabien requested changes to this revision.Fri, Oct 31, 16:29
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/script/sigcache.h
23 ↗(On Diff #56388)

?

This revision now requires changes to proceed.Fri, Oct 31, 16:29
PiRK updated this revision to Diff 56391.Fri, Oct 31, 17:37

remove unneeded XOnlyPubKey forward declaration. We keep CTransaction even if it is unrelated to the rest of the commit, because it is correct (used in CachingTransactionSignatureChecker)

Harbormaster completed remote builds in B34932: Diff 56391.Fri, Oct 31, 17:47
Fabien accepted this revision.Fri, Oct 31, 20:51
This revision is now accepted and ready to land.Fri, Oct 31, 20:51
Closed by commit rABC2a0800e3e55b: Expose CSignatureCache class in header (authored by TheCharlatan <seb.kung@gmail.com>, committed by PiRK). · Explain WhyMon, Nov 3, 09:25
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2a0800e3e55b: Expose CSignatureCache class in header.

Revision Contents
Changeset List

PathSize
src/
script/
39 lines
83 lines

Diff 56397

View Options

src/script/sigcache.h

Loading...
View Options

src/script/sigcache.cpp

Loading...