Paths

Table of Contentst

Differential D1887

remove some unused functions
ClosedPublic
Actions

Authored by deadalnix on Oct 5 2018, 13:02.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1d11a0da4d35: remove some unused functions
rABC1d11a0da4d35: remove some unused functions

Summary

Identified with cppcheck --enable=unusedFunction ..

GetSendBufferSize()'s last use removed in 991955ee81034dc3fbc1c2a8e60c04fc9e0b538c
SetPort()'s last use removed in 7e195e8459ad741368db6bb574981fccb1707268
GetfLargeWorkInvalidChainFound() was introduced in e3ba0ef95636290a3bb597ddd25d13ea13b034aa and never used

This is a backport of core PR10501

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 5 2018, 13:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 13:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3523: Diff 5290.Oct 5 2018, 13:19

jasonbcox accepted this revision.Oct 5 2018, 15:40

This revision is now accepted and ready to land.Oct 5 2018, 15:40

Closed by commit rABC1d11a0da4d35: remove some unused functions (authored by Marko Bencun <marko.bencun@monetas.net>, committed by deadalnix). · Explain WhyOct 6 2018, 09:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

3 lines

1 line

4 lines

1 line

5 lines

Diff 5306

src/net.h

Loading...

src/net.cpp

Loading...

src/netaddress.h

Loading...

src/netaddress.cpp

Loading...

src/warnings.h

Loading...

src/warnings.cpp

Loading...