Page MenuHomePhabricator
Differential D18870

refactor: Make uint256_tests no longer use deprecated BOOST_CHECK()
ClosedPublic
Actions

Authored by PiRK on Wed, Nov 5, 12:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4d9fdc4a072d: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK()
Summary

This is a partial backport of core#30436
https://github.com/bitcoin/bitcoin/pull/30436/commits/f11f816800ac520064a1e96871d0b4cc9601ced7

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Nov 5, 12:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 12:25
PiRK requested review of this revision.Wed, Nov 5, 12:25
teamcity edited the summary of this revision. (Show Details)Wed, Nov 5, 12:25
PiRK added a child revision: D18871: test: uint256 - Garbage suffixes and zero padding.Wed, Nov 5, 12:26
PiRK added inline comments.Wed, Nov 5, 12:30
src/test/uint256_tests.cpp
115–127 ↗(On Diff #56422)

D1526

Harbormaster completed remote builds in B34952: Diff 56422.Wed, Nov 5, 12:42
Fabien requested changes to this revision.Wed, Nov 5, 16:26
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/uint256_tests.cpp
115–127 ↗(On Diff #56422)

Why did you remove ? It's not a duplicate

This revision now requires changes to proceed.Wed, Nov 5, 16:26
PiRK requested review of this revision.Wed, Nov 5, 17:59
PiRK added inline comments.
src/test/uint256_tests.cpp
115–127 ↗(On Diff #56422)

I made it a template

Fabien accepted this revision.Wed, Nov 5, 18:51
This revision is now accepted and ready to land.Wed, Nov 5, 18:51
Fabien added inline comments.Wed, Nov 5, 18:51
src/test/uint256_tests.cpp
155 ↗(On Diff #56422)

Note to reviewer: it's called here

Closed by commit rABC4d9fdc4a072d: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK() (authored by Hodlinator <172445034+hodlinator@users.noreply.github.com>, committed by PiRK). · Explain WhyWed, Nov 5, 19:37
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4d9fdc4a072d: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().

Revision Contents
Changeset List

PathSize
src/
test/
275 lines
util/
6 lines
10 lines

Diff 56461

View Options

src/test/uint256_tests.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...