Differential D1888

Populate services in GetLocalAddress
ClosedPublic
Actions

Authored by deadalnix on Oct 5 2018, 13:36.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING47c230007e81: Populate services in GetLocalAddress
rABC47c230007e81: Populate services in GetLocalAddress

Summary

Previously if we didn't have any local addresses, GetLocalAddress would return
0.0.0.0 and then we'd swap in a peer's notion of our address in AdvertiseLocal,
but then nServices would never get set.

This is a backport of Core PR10424

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 5 2018, 13:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 13:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3525: Diff 5292.Oct 5 2018, 13:54

schancel accepted this revision.Oct 5 2018, 22:04

This revision is now accepted and ready to land.Oct 5 2018, 22:04

Closed by commit rABC47c230007e81: Populate services in GetLocalAddress (authored by Alex Morcos <morcos@chaincode.com>, committed by deadalnix). · Explain WhyOct 6 2018, 09:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

net.cpp

2 lines

Diff 5303

View Options

Populate services in GetLocalAddressClosedPublicActions