Page MenuHomePhabricator

guix: remove test-security/symbol-check scripts
ClosedPublic

Authored by PiRK on Fri, Nov 7, 09:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7a5211401e9e: guix: remove test-security/symbol-check scripts
Summary

These scripts are becoming more of nuisance, than a value-add;
particularly since we've been building releases using Guix. Adding new
(release bin) tests can be harder, because it requires constructing a
failing test, which is becoming less easy e.g trying to disable a
feature or protection that has been built into the compiler/toolchain by
default.

In the pre-Guix days, these were valuable to sanity-check the environment,
because we were pulling that pre-built from Ubuntu, with little control.
At this point, it's less clear what these scripts are (sanity) checking.

This is a backport of core#31818

Test Plan

I will run guix builds in a dependency of this diff just to confirm that these scripts are currently unused.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK published this revision for review.Fri, Nov 7, 12:57
Fabien requested changes to this revision.Fri, Nov 7, 13:30
Fabien added a subscriber: Fabien.

Please don't do this until we backported all the security improvements first. They serve as tests for these features in the meantime

This revision now requires changes to proceed.Fri, Nov 7, 13:30

NVM it's not the scripts but their tests which are worthless

This revision is now accepted and ready to land.Fri, Nov 7, 13:31