Paths

Table of Contentst

Differential D18923

[Cashtab] Do not allow users to list Firma below the bid price
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 12, 14:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC60c7df36b9ba: [Cashtab] Do not allow users to list Firma below the bid price

Summary

Every once in awhile someone lists Firma for 1 XEC instead of 1 dollar (or using the redeem feature)

There is no good reason to do this, so prevent it

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Nov 12, 14:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 12, 14:37

bytesofman edited the test plan for this revision. (Show Details)Wed, Nov 12, 14:38

Harbormaster completed remote builds in B35045: Diff 56571.Wed, Nov 12, 14:43

confirm with test

bytesofman published this revision for review.Wed, Nov 12, 15:05

Harbormaster completed remote builds in B35046: Diff 56572.Wed, Nov 12, 15:09

Fabien accepted this revision.Wed, Nov 12, 20:02

This revision is now accepted and ready to land.Wed, Nov 12, 20:02

Closed by commit rABC60c7df36b9ba: [Cashtab] Do not allow users to list Firma below the bid price (authored by bytesofman). · Explain WhyWed, Nov 12, 21:55

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC60c7df36b9ba: [Cashtab] Do not allow users to list Firma below the bid price.

Revision Contents
Changeset List

Path

Size

cashtab/

extension/

public/

manifest.json

2 lines

package-lock.json

4 lines

package.json

2 lines

src/

components/

Etokens/

Token/

index.tsx

442 lines

__tests__/

TokenActions.test.js

101 lines

Diff 56577

View Options

cashtab/extension/public/manifest.json

View Options

cashtab/package-lock.json

View Options

cashtab/package.json

View Options

cashtab/src/components/Etokens/Token/index.tsx

View Options

cashtab/src/components/Etokens/tests/TokenActions.test.js

[Cashtab] Do not allow users to list Firma below the bid priceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56577

cashtab/extension/public/manifest.json

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Etokens/Token/index.tsx

cashtab/src/components/Etokens/__tests__/TokenActions.test.js

[Cashtab] Do not allow users to list Firma below the bid price
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Etokens/tests/TokenActions.test.js