Differential D18925

[ecash-agora] Patch version bump for latest ecash-wallet dep
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 12, 23:07.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd01ea577641b: [ecash-agora] Patch version bump for latest ecash-wallet dep

Summary

It's much better for users with all of these libs in the same app if all of the peer deps are also the latest version

Argument that ... should just have one lib. But I think the value of modularity still outweighs the inconvenience of these maintenace updates.

Test Plan

CI tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Nov 12, 23:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 12, 23:07

bytesofman published this revision for review.Wed, Nov 12, 23:07

Harbormaster completed remote builds in B35050: Diff 56579.Wed, Nov 12, 23:14

rebase

Harbormaster completed remote builds in B35052: Diff 56581.Thu, Nov 13, 04:12

Can this be automated ?

This revision is now accepted and ready to land.Thu, Nov 13, 08:18

Closed by commit rABCd01ea577641b: [ecash-agora] Patch version bump for latest ecash-wallet dep (authored by bytesofman). · Explain WhyThu, Nov 13, 12:15

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd01ea577641b: [ecash-agora] Patch version bump for latest ecash-wallet dep.

In D18925#431537, @Fabien wrote:

Can this be automated ?

It probably can but a robust approach is unclear at the moment

Here's something that could work

We could have a herald rule where if ecash-wallet changes, something in CI runs to confirm that ecash-agora version is bumped
We would need to make sure in CI that ecash-wallet publishes before ecash-agora

For now, I'm kinda the only one changing these libs, and I also have apps that use both of them, so it's pretty straightforward to keep on top of it manually. We are also still in a (somewhat) fluid state as the exact relationship between ecash-wallet and ecash-agora isn't really worked out; i.e. I haven't finished implementing all the agora support in ecash-wallet. Possibly this dep hierarchy could change, and this I think is the main reason to avoid automation right now.