test: cover read-only blockstore
Needs ReviewPublic
Actions

Authored by PiRK on Wed, Nov 19, 17:08.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Add a test to cover the behavior described in https://github.com/bitcoin/bitcoin/issues/2039, in preparation for fixing it.
I massaged the functional test: fewer levels of try-except wrapping, deduplication of the platform specific code (only the command name changes based on the OS)

This is a backport of core#28545, core#27850 and core#28660
Depends on D18969

Test Plan

ninja check check-functional

Try with the chattr unavailable on linux and check that the test is reported as skipped.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr27861

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35125
Build 69708: Build Diff	lint-circular-dependencies · build-clang · build-clang-tidy · build-diff · build-debug · build-without-wallet
Build 69707: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Nov 19, 17:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 19, 17:08

PiRK requested review of this revision.Wed, Nov 19, 17:08

teamcity edited the summary of this revision. (Show Details)Wed, Nov 19, 17:09

PiRK added inline comments.Wed, Nov 19, 17:10

test/functional/feature_reindex_readonly.py
55–58 ↗	(On Diff #56687)	this is an improvement over the original test which succeeds even when it does not test anything. We will see that test is skipped instead of green.