Page MenuHomePhabricator
Differential D18964

util: move threadinterrupt into util
ClosedPublic
Actions

Authored by PiRK on Wed, Nov 19, 10:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc6b38d1d9b9e: util: move threadinterrupt into util
Summary

This is a backport of core#26292

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Nov 19, 10:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 19, 10:31
PiRK requested review of this revision.Wed, Nov 19, 10:31
teamcity edited the summary of this revision. (Show Details)Wed, Nov 19, 10:31
Harbormaster completed remote builds in B35112: Diff 56676.Wed, Nov 19, 10:36
teamcity added a comment.Wed, Nov 19, 10:36
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/56676'
Triggered 2025-11-19 10:31:07 by 'Phabricator Staging (phabricator-staging)'
Started 2025-11-19 10:36:38 on agent 'N/A'
Finished 2025-11-19 10:36:38 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1016018 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[10:31:07]W: bt15 (5m:30s)
[10:31:07]i: TeamCity server version is 2025.03.1 (build 186125)
[10:31:07] : Finalize build settings
[10:31:07] : Collecting changes in 2 VCS roots
[10:31:07] :	 [Collecting changes in 2 VCS roots] VCS Root details
[10:31:07] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[10:31:07] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[10:31:08]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (1s)
[10:31:08]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure'
[10:36:38]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
teamcity added a comment.Wed, Nov 19, 10:36
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/56676'
Triggered 2025-11-19 10:31:07 by 'Phabricator Staging (phabricator-staging)'
Started 2025-11-19 10:36:38 on agent 'N/A'
Finished 2025-11-19 10:36:38 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1016016 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[10:31:07]W: bt15 (5m:30s)
[10:31:07]i: TeamCity server version is 2025.03.1 (build 186125)
[10:31:07] : Finalize build settings
[10:31:07] : Collecting changes in 2 VCS roots
[10:31:07] :	 [Collecting changes in 2 VCS roots] VCS Root details
[10:31:07] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[10:31:07] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[10:31:08]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (1s)
[10:31:08]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper3215523750014678699.sh ls-remote origin
[10:31:08]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (1s)
[10:31:08]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper12656431892021015042.sh ls-remote origin
[10:31:08]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[10:31:08]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': phabricator-ssh-exec: Unable to establish a connection to any database host (while trying "reviews_bitcoinabc_project"). All masters and replicas are completely unreachable.
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': AphrontConnectionQueryException: Attempt to connect to phabricator@127.0.0.1 failed with error #1040: Too many connections.
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[10:31:09]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[10:31:09]i: VCS root 'Bitcoin ABC Staging': [2025-11-19 10:31:09] EXCEPTION: (PhabricatorClusterStrandedException) Unable to establish a connection to any database host (while trying "reviews_bitcoinabc_config"). All masters and replicas are completely unreachable.
[10:31:09]i: VCS root 'Bitcoin ABC Staging': 
[10:31:09]i: VCS root 'Bitcoin ABC Staging': AphrontConnectionQueryException: Attempt to connect to phabricator@127.0.0.1 failed with error #1040: Too many connections. at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:177]
[10:31:09]i: VCS root 'Bitcoin ABC Staging': arcanist(head=master, ref.master=f0a2b699ba62), phabricator(head=master, ref.master=dec95228a241)
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #0 PhabricatorLiskDAO::raiseUnreachable(string, AphrontConnectionQueryException) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:134]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #1 PhabricatorLiskDAO::newClusterConnection(string, string, string) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:70]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #2 PhabricatorLiskDAO::establishLiveConnection(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:856]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #3 LiskDAO::establishConnection(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:521]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #4 LiskDAO::loadRawDataWhere(string, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:481]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #5 LiskDAO::loadAllWhere(string, string) called at [<phabricator>/src/infrastructure/env/PhabricatorConfigDatabaseSource.php:18]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #6 PhabricatorConfigDatabaseSource::loadConfig(string) called at [<phabricator>/src/infrastructure/env/PhabricatorConfigDatabaseSource.php:7]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #7 PhabricatorConfigDatabaseSource::__construct(string) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:262]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #8 PhabricatorEnv::buildConfigurationSourceStack(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:95]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #9 PhabricatorEnv::initializeCommonEnvironment(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:75]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #10 PhabricatorEnv::initializeScriptEnvironment(boolean) called at [<phabricator>/scripts/init/lib.php:26]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #11 init_phabricator_script(array) called at [<phabricator>/scripts/init/init-script.php:9]
[10:31:09]i: VCS root 'Bitcoin ABC Staging':   #12 require_once(string) called at [<phabricator>/scripts/ssh/ssh-exec.php:7]
[10:31:09]i: VCS root 'Bitcoin ABC Staging': fatal: Could not read from remote repository.
[10:31:09]i: VCS root 'Bitcoin ABC Staging': 
[10:31:09]i: VCS root 'Bitcoin ABC Staging': Please make sure you have the correct access rights
[10:31:09]i: VCS root 'Bitcoin ABC Staging': and the repository exists.
[10:36:38]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
teamcity added a comment.Wed, Nov 19, 11:00
Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/56676'
Triggered 2025-11-19 11:00:13 by 'Pierre (pirk)'
Started 2025-11-19 11:00:13 on agent 'N/A'
Finished 2025-11-19 11:00:13 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1016026 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[11:00:13]W: bt15
[11:00:13]i: TeamCity server version is 2025.03.1 (build 186125)
[11:00:13] : Finalize build settings
[11:00:13]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
PiRK added a comment.Wed, Nov 19, 11:01

the failures seem unrelated, rerunning

PiRK updated this revision to Diff 56678.Wed, Nov 19, 11:31

rebase

Harbormaster completed remote builds in B35114: Diff 56678.Wed, Nov 19, 11:31
teamcity added a comment.Wed, Nov 19, 11:31
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/56678'
Triggered 2025-11-19 11:31:24 by 'Phabricator Staging (phabricator-staging)'
Started 2025-11-19 11:31:26 on agent 'N/A'
Finished 2025-11-19 11:31:26 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1016044 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[11:31:24]W: bt15 (2s)
[11:31:24]i: TeamCity server version is 2025.03.1 (build 186125)
[11:31:24] : Finalize build settings
[11:31:24] : Collecting changes in 2 VCS roots
[11:31:24] :	 [Collecting changes in 2 VCS roots] VCS Root details
[11:31:24] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[11:31:24] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[11:31:24]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (1s)
[11:31:24]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (1s)
[11:31:24]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper16921439785453421389.sh ls-remote origin
[11:31:24]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper4452990353311475435.sh ls-remote origin
[11:31:24]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[11:31:24]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': [2025-11-19 11:31:25] EXCEPTION: (PhabricatorClusterStrandedException) Unable to establish a connection to any database host (while trying "reviews_bitcoinabc_config"). All masters and replicas are completely unreachable.
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': AphrontConnectionQueryException: Attempt to connect to phabricator@127.0.0.1 failed with error #1040: Too many connections. at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:177]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': arcanist(head=master, ref.master=f0a2b699ba62), phabricator(head=master, ref.master=dec95228a241)
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #0 PhabricatorLiskDAO::raiseUnreachable(string, AphrontConnectionQueryException) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:134]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #1 PhabricatorLiskDAO::newClusterConnection(string, string, string) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:70]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #2 PhabricatorLiskDAO::establishLiveConnection(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:856]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #3 LiskDAO::establishConnection(string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:521]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #4 LiskDAO::loadRawDataWhere(string, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:481]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #5 LiskDAO::loadAllWhere(string, string) called at [<phabricator>/src/infrastructure/env/PhabricatorConfigDatabaseSource.php:18]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #6 PhabricatorConfigDatabaseSource::loadConfig(string) called at [<phabricator>/src/infrastructure/env/PhabricatorConfigDatabaseSource.php:7]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #7 PhabricatorConfigDatabaseSource::__construct(string) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:262]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #8 PhabricatorEnv::buildConfigurationSourceStack(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:95]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #9 PhabricatorEnv::initializeCommonEnvironment(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:75]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #10 PhabricatorEnv::initializeScriptEnvironment(boolean) called at [<phabricator>/scripts/init/lib.php:26]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #11 init_phabricator_script(array) called at [<phabricator>/scripts/init/init-script.php:9]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure':   #12 require_once(string) called at [<phabricator>/scripts/ssh/ssh-exec.php:7]
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[11:31:25]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[11:31:25]i: VCS root 'Bitcoin ABC Staging': phabricator-ssh-exec: Unable to establish a connection to any database host (while trying "reviews_bitcoinabc_user"). All masters and replicas are completely unreachable.
[11:31:25]i: VCS root 'Bitcoin ABC Staging': 
[11:31:25]i: VCS root 'Bitcoin ABC Staging': AphrontConnectionQueryException: Attempt to connect to phabricator@127.0.0.1 failed with error #1040: Too many connections.
[11:31:25]i: VCS root 'Bitcoin ABC Staging': fatal: Could not read from remote repository.
[11:31:25]i: VCS root 'Bitcoin ABC Staging': 
[11:31:25]i: VCS root 'Bitcoin ABC Staging': Please make sure you have the correct access rights
[11:31:25]i: VCS root 'Bitcoin ABC Staging': and the repository exists.
[11:31:26]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
PiRK added a child revision: D18965: util: Add SignalInterrupt class and use in shutdown.cpp.Wed, Nov 19, 14:41
Fabien accepted this revision.Thu, Nov 20, 08:37
This revision is now accepted and ready to land.Thu, Nov 20, 08:37
Closed by commit rABCc6b38d1d9b9e: util: move threadinterrupt into util (authored by fanquake <fanquake@gmail.com>, committed by PiRK). · Explain WhyThu, Nov 20, 14:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc6b38d1d9b9e: util: move threadinterrupt into util.

Revision Contents
Changeset List

PathSize
src/
4 lines
3 lines
1 line
index/
2 lines
2 lines
2 lines
1 line
test/
2 lines
2 lines
util/
2 lines
2 lines
util/
6 lines
2 lines

Diff 56695

View Options

src/CMakeLists.txt

Loading...
View Options

src/i2p.h

Loading...
View Options

src/i2p.cpp

Loading...
View Options

src/index/base.h

Loading...
View Options

src/mapport.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/test/i2p_tests.cpp

Loading...
View Options

src/test/sock_tests.cpp

Loading...
View Options

src/threadinterrupt.h

Loading...
View Options

src/threadinterrupt.cpp

Loading...
View Options

src/util/sock.h

Loading...
View Options

src/util/sock.cpp

Loading...
View Options

src/util/threadinterrupt.h

Loading...
View Options

src/util/threadinterrupt.cpp

Loading...