Page MenuHomePhabricator

[electrum] appimage: bump appimagetool to new version/repo
ClosedPublic

Authored by PiRK on Wed, Nov 26, 16:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC54d2ecc63be5: [electrum] appimage: bump appimagetool to new version/repo
Summary

This is a backport of electrum#7785 and electrum#10019

Depends on D19001

build appimage: bump pkg2appimage version

should fix https://github.com/spesmilo/electrum/issues/7784
by including commit https://github.com/AppImage/pkg2appimage/commit/1e3ecde6b92ef198405463415b8090a4435d0cb0

Updates the appimage build scripts to use the newer
https://github.com/AppImage/appimagetool tool to bundle the appimage
instead of the discontinued https://github.com/AppImage/AppImageKit.
To prevent the new appimagetool from downloading a random "latest"
appimage runtime (type2-runtime) binary this PR also adds
functionality to clone and build
https://github.com/AppImage/type2-runtime from source. This is done
using the build scripts provided in the type2-runtime repository,
however the Dockerfile they use for building is replaced by a copy with
pinned package versions to prevent issues with reproducibility.

This should fix the issue of missing libfuse2 which users of the appimage
have on "modern" distributions.
The new type2-runtime is statically linked and includes the required
dependencies now instead of relying on the host to provide it.

Test Plan

contrib/build-linux/appimage/build.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK published this revision for review.Wed, Nov 26, 16:08
PiRK retitled this revision from appimage: bump appimagetool to new version/repo to [electrum] appimage: bump appimagetool to new version/repo.Wed, Nov 26, 16:11
This revision is now accepted and ready to land.Thu, Nov 27, 10:30