Differential D19009

[electrum] fix transaction_dialog when creating a multisig partially signed transaction
ClosedPublic
Actions

Authored by PiRK on Mon, Dec 1, 08:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCeba54e1de99e: [electrum] fix transaction_dialog when creating a multisig partially signed…

Summary

These Two changes were missed in D18324. The error can be triggered with multisig wallets or using the load transaction from text menu with a partially signed transaction.

Test Plan

with a 2-of-m multisig wallet, create a transaction, export the transaction to hex, load it from another wallet, sign, broadcast

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Dec 1, 08:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 1, 08:40

PiRK requested review of this revision.Mon, Dec 1, 08:40

Harbormaster completed remote builds in B35176: Diff 56784.Mon, Dec 1, 08:47

found one more instance to fix...

that other instance of tx_external_keypairs is not a direct API access, but a dynamic access via hooks. I will fix this in a separate diff, because the hooks are broken in multiple ways

PiRK requested review of this revision.Mon, Dec 1, 10:05

PiRK added a child revision: D19010: [electrum] fix or remove hooks in send_tab.Mon, Dec 1, 10:20

Fabien accepted this revision.Mon, Dec 1, 11:23

This revision is now accepted and ready to land.Mon, Dec 1, 11:23

Closed by commit rABCeba54e1de99e: [electrum] fix transaction_dialog when creating a multisig partially signed… (authored by PiRK). · Explain WhyMon, Dec 1, 11:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCeba54e1de99e: [electrum] fix transaction_dialog when creating a multisig partially signed….