random: move rand256() and randbytes() to .h file
Changes PlannedPublic
Actions

Authored by PiRK on Wed, Dec 3, 16:07.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This is a partial backport of core#29625
https://github.com/bitcoin/bitcoin/pull/29625/commits/b3b382dde202ad508baf553817c5b38fdd2d4a0c
Depends on D19041

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35218
Build 69894: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 69893: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Dec 3, 16:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Dec 3, 16:07

PiRK requested review of this revision.Wed, Dec 3, 16:07

teamcity edited the summary of this revision. (Show Details)Wed, Dec 3, 16:07

PiRK added a child revision: D19043: random: add a few noexcepts to FastRandomContext.Wed, Dec 3, 16:08

PiRK planned changes to this revision.Wed, Dec 3, 16:14

Harbormaster completed remote builds in B35218: Diff 56850.Wed, Dec 3, 16:17

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[207/540] Running utility command for check-avalanche-stakingrewards_tests
[208/540] avalanche: testing proofpool_tests
[209/540] Running utility command for check-avalanche-proofpool_tests
[210/540] avalanche: testing stakecontendercache_tests
[211/540] Running utility command for check-avalanche-stakecontendercache_tests
[212/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[213/540] Linking CXX executable src/pow/test/test-pow
[214/540] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[215/540] pow: testing daa_tests
[216/540] Running utility command for check-pow-daa_tests
[217/540] pow: testing eda_tests
[218/540] Running utility command for check-pow-eda_tests
[219/540] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[220/540] pow: testing grasberg_tests
[221/540] Running utility command for check-pow-grasberg_tests
[222/540] Linking CXX executable src/seeder/test/test-seeder
[223/540] seeder: testing db_tests
[224/540] Running utility command for check-seeder-db_tests
[225/540] seeder: testing message_writer_tests
[226/540] Running utility command for check-seeder-message_writer_tests
[227/540] seeder: testing options_tests
[228/540] Running utility command for check-seeder-options_tests
[229/540] seeder: testing p2p_messaging_tests
[230/540] Running utility command for check-seeder-p2p_messaging_tests
[231/540] seeder: testing parse_name_tests
[232/540] Running utility command for check-seeder-parse_name_tests
[233/540] seeder: testing write_name_tests
[234/540] Running utility command for check-seeder-write_name_tests
[235/540] Running seeder test suite
PASSED: seeder test suite
[236/540] avalanche: testing voterecord_tests
[237/540] Running utility command for check-avalanche-voterecord_tests
[238/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[239/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[240/540] avalanche: testing peermanager_tests
[241/540] Running utility command for check-avalanche-peermanager_tests
[242/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[243/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[244/540] pow: testing aserti32d_tests
[245/540] Running utility command for check-pow-aserti32d_tests
[246/540] Running pow test suite
PASSED: pow test suite
[247/540] avalanche: testing processor_tests
[248/540] Running utility command for check-avalanche-processor_tests
[249/540] Running avalanche test suite
PASSED: avalanche test suite
[250/540] Test Bitcoin utilities...
[251/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[252/540] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[253/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[254/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[255/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[256/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[257/540] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[258/540] Linking CXX executable src/qt/test/test_bitcoin-qt
[259/540] bitcoin-qt: testing test_bitcoin-qt
[260/540] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:


============================== 20 passed in 0.76s ==============================
[208/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/options_tests.cpp.o
[209/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/db_tests.cpp.o
[210/545] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[211/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[212/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/daa_tests.cpp.o
[213/545] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/__/chronik/test/bridgeprimitives_tests.cpp.o
[214/545] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[215/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/eda_tests.cpp.o
[216/545] Linking CXX executable src/seeder/test/test-seeder
[217/545] seeder: testing db_tests
[218/545] Running utility command for check-seeder-db_tests
[219/545] seeder: testing message_writer_tests
[220/545] Running utility command for check-seeder-message_writer_tests
[221/545] seeder: testing options_tests
[222/545] Running utility command for check-seeder-options_tests
[223/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/aserti32d_tests.cpp.o
[224/545] seeder: testing p2p_messaging_tests
[225/545] Running utility command for check-seeder-p2p_messaging_tests
[226/545] seeder: testing parse_name_tests
[227/545] Running utility command for check-seeder-parse_name_tests
[228/545] seeder: testing write_name_tests
[229/545] Running utility command for check-seeder-write_name_tests
[230/545] Running seeder test suite
PASSED: seeder test suite
[231/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[232/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[233/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[234/545] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/grasberg_tests.cpp.o
[235/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[236/545] Linking CXX executable src/pow/test/test-pow
[237/545] pow: testing daa_tests
[238/545] pow: testing eda_tests
[239/545] Running utility command for check-pow-daa_tests
[240/545] Test Bitcoin utilities...
[241/545] Running utility command for check-pow-eda_tests
[242/545] pow: testing grasberg_tests
[243/545] Running utility command for check-pow-grasberg_tests
[244/545] pow: testing aserti32d_tests
[245/545] Running utility command for check-pow-aserti32d_tests
[246/545] Running pow test suite
PASSED: pow test suite
[247/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[248/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[249/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[250/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[251/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[252/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[253/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[254/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[255/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[256/545] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[257/545] Linking CXX executable src/qt/test/test_bitcoin-qt
[258/545] bitcoin-qt: testing test_bitcoin-qt
[259/545] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1