Page MenuHomePhabricator
Differential D1929

[qa] make extended cutoff configurable
ClosedPublic
Actions

Authored by schancel on Oct 14 2018, 22:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2df90fe06893: [qa] make extended cutoff configurable
rABC2df90fe06893: [qa] make extended cutoff configurable
Summary

Add a 'cutoff' flag to test_runner.py that is an integer number of seconds.
The cutoff flag controls which tests run by how long they take in seconds.

Test Plan
./test/functional/test_runner.py --cutoff=6000

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Oct 14 2018, 22:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2018, 22:17
teamcity added a subscriber: teamcity.Oct 14 2018, 22:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a subscriber: deadalnix.Oct 14 2018, 22:21
deadalnix added inline comments.
test/functional/test_runner.py
226 ↗(On Diff #5415)

Can we keep the semantic of --extended to basically means no cutoff if no value is provided ?

teamcity added a comment.Oct 14 2018, 22:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3598: Diff 5415.Oct 14 2018, 22:27
schancel updated this revision to Diff 5416.Oct 15 2018, 01:32

Address feedback

teamcity added a comment.Oct 15 2018, 01:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel edited the summary of this revision. (Show Details)Oct 15 2018, 01:34
schancel edited the test plan for this revision. (Show Details)
teamcity added a comment.Oct 15 2018, 01:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3599: Diff 5416.Oct 15 2018, 01:42
deadalnix accepted this revision.Oct 15 2018, 08:52
This revision is now accepted and ready to land.Oct 15 2018, 08:52
Closed by commit rABC2df90fe06893: [qa] make extended cutoff configurable (authored by schancel). · Explain WhyOct 15 2018, 15:43
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D3691: Fix a bug where the TeamCity build only reports one of the test_runner runs.Jul 18 2019, 01:25

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines
test/
functional/
10 lines

Diff 5417

View Options

contrib/teamcity/build.sh

Loading...
View Options

test/functional/test_runner.py

Loading...