Differential D1978

Fix that CWallet::AbandonTransaction would only traverse one level
ClosedPublic
Actions

Authored by schancel on Oct 29 2018, 17:39.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING00c72639b0c7: Fix that CWallet::AbandonTransaction would only traverse one level
rABC00c72639b0c7: Fix that CWallet::AbandonTransaction would only traverse one level

Summary

Prior to this change, it would mark only the first layer of
child transactions abandoned, due to always following the input hashTx
rather than the current now tx.

Backport of Core PR13652

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13652

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3704
Build 5483: Bitcoin ABC Buildbot (legacy)
Build 5482: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 29 2018, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2018, 17:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3704: Diff 5563.Oct 29 2018, 17:49

jasonbcox accepted this revision.Oct 29 2018, 18:27

This revision is now accepted and ready to land.Oct 29 2018, 18:27

Closed by commit rABC00c72639b0c7: Fix that CWallet::AbandonTransaction would only traverse one level (authored by Ben Woosley <ben.woosley@gmail.com>, committed by schancel). · Explain WhyOct 29 2018, 23:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

2 lines

test/

functional/

abandonconflict.py

13 lines

Diff 5563

View Options

src/wallet/wallet.cpp