Page MenuHomePhabricator
Differential D2017

[cleanup] De-globalize rpc configuration variables
ClosedPublic
Actions

Authored by schancel on Nov 7 2018, 02:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGbbb88c512e86: [cleanup] De-globalize rpc configuration variables
rABCbbb88c512e86: [cleanup] De-globalize rpc configuration variables
Summary

As per title

Test Plan
make check && ./test/functional/test_runner.py httpbasics

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Nov 7 2018, 02:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2018, 02:15
teamcity added a subscriber: teamcity.Nov 7 2018, 02:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3801: Diff 5689.Nov 7 2018, 02:23
teamcity added a comment.Nov 7 2018, 02:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel added a child revision: D2018: [cleanup] De-globalize blocksize related parameters.Nov 7 2018, 02:30
jasonbcox accepted this revision.Nov 10 2018, 00:59
jasonbcox added a subscriber: jasonbcox.

test_runner.py httpbasics should be part of the test plan

This revision is now accepted and ready to land.Nov 10 2018, 00:59
schancel edited the test plan for this revision. (Show Details)Nov 13 2018, 18:30
Closed by commit rABCbbb88c512e86: [cleanup] De-globalize rpc configuration variables (authored by schancel). · Explain WhyNov 13 2018, 18:57
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
8 lines
2 lines

Diff 5808

View Options

src/config.h

Loading...
View Options

src/globals.h

Loading...
View Options

src/globals.cpp

Loading...