Page MenuHomePhabricator
Differential D2034

Fix functional test --help raising an exception
ClosedPublic
Actions

Authored by Fabien on Nov 9 2018, 21:45.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGc70157147763: Fix functional test --help raising an exception
rABCc70157147763: Fix functional test --help raising an exception
Summary

The test_framework.py --srcdir option referenced the default path with
%default in the help, causing argparse to expect an integer to format
the string (%d).

Test Plan
./test/functional/test_runner.py --help

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 9 2018, 21:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2018, 21:45
teamcity added a subscriber: teamcity.Nov 9 2018, 21:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 5726.Nov 9 2018, 21:51

Fix missing parenthesis

teamcity added a comment.Nov 9 2018, 21:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 9 2018, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3823: Diff 5725.Nov 9 2018, 21:56
teamcity added a comment.Nov 9 2018, 22:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3824: Diff 5726.Nov 9 2018, 22:01
schancel accepted this revision.Nov 9 2018, 23:07
This revision is now accepted and ready to land.Nov 9 2018, 23:07
Closed by commit rABCc70157147763: Fix functional test --help raising an exception (authored by Fabien). · Explain WhyNov 12 2018, 21:07
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
2 lines

Diff 5774

View Options

test/functional/test_framework/test_framework.py

Loading...