Differential D2034

Fix functional test --help raising an exception
ClosedPublic
Actions

Authored by Fabien on Nov 9 2018, 21:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc70157147763: Fix functional test --help raising an exception
rABCc70157147763: Fix functional test --help raising an exception

Summary

The test_framework.py --srcdir option referenced the default path with
%default in the help, causing argparse to expect an integer to format
the string (%d).

Test Plan

./test/functional/test_runner.py --help

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_test_runner_help

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3824
Build 5721: Bitcoin ABC Buildbot (legacy)
Build 5720: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 9 2018, 21:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2018, 21:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fix missing parenthesis

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3823: Diff 5725.Nov 9 2018, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3824: Diff 5726.Nov 9 2018, 22:01

schancel accepted this revision.Nov 9 2018, 23:07

This revision is now accepted and ready to land.Nov 9 2018, 23:07

Closed by commit rABCc70157147763: Fix functional test --help raising an exception (authored by Fabien). · Explain WhyNov 12 2018, 21:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

2 lines

Diff 5726

View Options

test/functional/test_framework/test_framework.py

Fix functional test --help raising an exceptionClosedPublicActions