Differential D2053

[macOS] Remove DS_Store WindowBounds bytes object
ClosedPublic
Actions

Authored by schancel on Nov 12 2018, 22:30.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe5bc797172e1: [macOS] Remove DS_Store WindowBounds bytes object
rABCe5bc797172e1: [macOS] Remove DS_Store WindowBounds bytes object

Summary

Backport Core PR14416

Fixes an issue with the dmg building on osx 10.14

Test Plan

make deploy

test opening image

Diff Detail

Repository

rABC Bitcoin ABC

Branch

backport-pr14416

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3870
Build 5813: Bitcoin ABC Buildbot (legacy)
Build 5812: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 12 2018, 22:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 12 2018, 22:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3870: Diff 5779.Nov 12 2018, 22:40

jasonbcox accepted this revision.Nov 13 2018, 03:09

This revision is now accepted and ready to land.Nov 13 2018, 03:09

Closed by commit rABCe5bc797172e1: [macOS] Remove DS_Store WindowBounds bytes object (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by schancel). · Explain WhyNov 13 2018, 04:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

macdeploy/

custom_dsstore.py

2 lines

Diff 5779

View Options

contrib/macdeploy/custom_dsstore.py

[macOS] Remove DS_Store WindowBounds bytes objectClosedPublicActions