Differential D2082

[qa] Fix invalidblockrequest to work with magnetic anomaly upgrade
ClosedPublic
Actions

Authored by schancel on Nov 18 2018, 00:50.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd9b8913c4204: [qa] Fix invalidblockrequest to work with magnetic anomaly upgrade
rSTAGINGd9b8913c4204: [qa] Fix invalidblockrequest to work with magnetic anomaly upgrade

Summary

This update fixes issues with CTOR and CLEANSTACK enforcement after the 15th of November 2018.

Test Plan

./test/functional/test_runner.py invalidblockrequest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Nov 18 2018, 00:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2018, 00:50

jasonbcox planned changes to this revision.Nov 18 2018, 00:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3939: Diff 5865!Nov 18 2018, 00:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Fix test completely

schancel retitled this revision from [WIP] Apply CTOR logic to invalidblockrequest correctly and fix duplicate transactions test in invalidblockrequest.py to [qa] Fix invalidblockrequest to work with magnetic anomaly upgrade.Nov 18 2018, 04:02

schancel edited the summary of this revision. (Show Details)

schancel edited the test plan for this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel commandeered this revision.Nov 18 2018, 04:06

schancel removed a reviewer: schancel.

schancel added a reviewer: jasonbcox.

jasonbcox accepted this revision.Nov 18 2018, 04:09

This revision is now accepted and ready to land.Nov 18 2018, 04:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3946: Diff 5874!Nov 18 2018, 04:10

Closed by commit rABCd9b8913c4204: [qa] Fix invalidblockrequest to work with magnetic anomaly upgrade (authored by jasonbcox, committed by schancel). · Explain WhyNov 18 2018, 04:10

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			test/functional/invalidblockrequest.py (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5865	0e31ab2		Nov 18 2018, 00:49	★	★
Diff 2	5874	0e31ab2	Fix test completely	Nov 18 2018, 04:02	★	★
Diff 3	5875	388d3c1	rABCd9b8913c420408961cd313dc9fb07ffcb3d4c2ec	Nov 18 2018, 04:10	★	★

Diff 5875

View Options

test/functional/invalidblockrequest.py

[qa] Fix invalidblockrequest to work with magnetic anomaly upgradeClosedPublicActions