As per title. Add CTOR ordering to test block construction. Use
NULLDUMMY instead of CLEANSTACK for checking consensus vs non-consensus
script cache behavior.
This is a better approach toward fixing that test.
|163 ↗||(On Diff #5898)|
I don't think this really warrant to modify the test framework.
|202 ↗||(On Diff #5898)|
It's the last item. You are pushing onto a stack so the item you push first end up being the last item on the stack.
|1084 ↗||(On Diff #5903)|
|1088 ↗||(On Diff #5903)|
|185 ↗||(On Diff #5903)|
There is no point in bringing the key store in there. You are building the script to begin with so anything you'll pull of the store you already have.
|188 ↗||(On Diff #5903)|
I'm not sure why you want to do P2SH here instead of bare multisig. If there is a reason, it should be mentioned. if there is no reason, then don't do it.
|200 ↗||(On Diff #5903)|
This would benefit being scoped to destruct the temporaries.
|202 ↗||(On Diff #5903)|
This is not spending, this is mining.
|243 ↗||(On Diff #5903)|
You can sign the exact same ways as before. You just need to push the non nulldummy element.