Process transaction in reverse order in DisconnectedBlockTransactions::addForBlock
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2018, 23:30.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf3bd9f54e0ff: Process transaction in reverse order in DisconnectedBlockTransactions…
rABCf3bd9f54e0ff: Process transaction in reverse order in DisconnectedBlockTransactions…

Summary

It odesn't change anything for CTOR blocks, but makes TTOR block slightly faster to process, so that should help IBD.

Test Plan

Do IBD on testnet.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addForBlockspeedup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4006
Build 6084: Bitcoin ABC Buildbot (legacy)
Build 6083: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2018, 23:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 23:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4006: Diff 5952.Nov 19 2018, 23:42

schancel accepted this revision.Nov 19 2018, 23:48

This revision is now accepted and ready to land.Nov 19 2018, 23:48

Closed by commit rABCf3bd9f54e0ff: Process transaction in reverse order in DisconnectedBlockTransactions… (authored by deadalnix). · Explain WhyNov 21 2018, 12:13

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

2 lines

Diff 5952

View Options

Process transaction in reverse order in DisconnectedBlockTransactions::addForBlockClosedPublicActions