Remove leftover from the schnorr experiment
ClosedPublic
Actions

Authored by freetrader on Jun 21 2017, 23:11.

Details

Reviewers

deadalnix
MattBitprim

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa737cabe0271: Remove leftover from the schnorr experiment
rABCa737cabe0271: Remove leftover from the schnorr experiment

Summary

Removed the residual file from the schnorr experiment: src/bench_schnorr_verify.c

Test Plan

make check
python3 qa/pull-tests/rpc-tests.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cleanupschnorr

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 383
Build 383: arc lint + arc unit

Event Timeline

MattBitprim created this revision.Jun 21 2017, 23:11

Owners added a reviewer: Restricted Owners Package.Jun 21 2017, 23:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2017, 23:11

In case of changing compiled files source tree, make check should be added to Test Plan.

Indeed, if you don't rebuild the project, running the python tests only test the old code.

The test plan needs to be updated.

This revision now requires changes to proceed.Jun 22 2017, 12:37

MattBitprim edited the test plan for this revision. (Show Details)Jun 22 2017, 14:37

deadalnix accepted this revision.Jun 22 2017, 15:10

This revision is now accepted and ready to land.Jun 22 2017, 15:10

Taking this to close / land as there seems to be no outstanding action required.

Closed by commit rABCa737cabe0271: Remove leftover from the schnorr experiment (authored by MattBitprim, committed by freetrader). · Explain WhyJun 23 2017, 23:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

bench_schnorr_verify.c

Diff 614

View Options

src/secp256k1/src/bench_schnorr_verify.c

Remove leftover from the schnorr experimentClosedPublicActions