fix a memory leak in test_framework's key.py
ClosedPublic
Actions

Authored by markblundeberg on Feb 3 2019, 20:38.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd7c45b8b4c08: fix a memory leak in test_framework's key.py
rABCd7c45b8b4c08: fix a memory leak in test_framework's key.py

Summary

EC_KEY_set_private_key stores a *copy* of the provided bignum, thus the
private key here would be kept in memory permanently.

https://docs.huihoo.com/doxygen/openssl/1.0.1c/ec__key_8c.html

Test Plan

ran abc-replay-protection.py which uses this code; no problems occur.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Feb 3 2019, 20:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2019, 20:38

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4851: Diff 7143.Feb 3 2019, 20:54

deadalnix accepted this revision.Feb 4 2019, 12:16

This revision is now accepted and ready to land.Feb 4 2019, 12:16

Closed by commit rABCd7c45b8b4c08: fix a memory leak in test_framework's key.py (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 4 2019, 15:25

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGd7c45b8b4c08: fix a memory leak in test_framework's key.py.Sep 18 2019, 22:14

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

key.py

4 lines

Diff 7160

View Options

test/functional/test_framework/key.py

fix a memory leak in test_framework's key.pyClosedPublicActions