Page MenuHomePhabricator

Make scripts argument accept wildcards
Needs RevisionPublic

Authored by Fabien on Mon, Feb 4, 10:11.


Group Reviewers
Restricted Project

With the scripts being renamed, it could be interesting to allow for
specifying a category of functional tests to run. This diff adds
wildcard management in the script list given to Any
number of widcard can be used. For example, all the abc functional tests
can be run with ./test/functional/ abc-*

Test Plan

Run all the abc functional tests

./test/functional/ abc-*

Run and, only once each:

./test/functional/ rpc_bind
./test/functional/ rpc_bind

Run all the scripts containing the word "transaction":

./test/functional/ *transaction*

Run all the scripts ending with the word "transaction":

./test/functional/ *transaction

Diff Detail

rABC Bitcoin ABC
Lint OK
No Unit Test Coverage
Build Status
Buildable 4879
Build 7821: Bitcoin ABC Teamcity Staging
Build 7820: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Feb 4, 10:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Feb 4, 10:11
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Mon, Feb 4, 12:18
This revision is now accepted and ready to land.Mon, Feb 4, 12:18
deadalnix requested changes to this revision.Mon, Feb 4, 12:20
deadalnix added inline comments.
227 ↗(On Diff #7152)

This will not simply remove extension. It breaks existing semantic, and frankly, for no good reasons.

This revision now requires changes to proceed.Mon, Feb 4, 12:20
Fabien updated this revision to Diff 7185.Tue, Feb 5, 09:24

Back to re.sub() instead of replace()

deadalnix requested changes to this revision.Tue, Feb 5, 14:44

This shows all the sign of code that has been banged on until it more or less passes some smoke test.

The '.py$' being removed from various places. The argument passed being kind of regex kind of not. This code has not been designed in any way, it just happen to work in some specific case.

This revision now requires changes to proceed.Tue, Feb 5, 14:44