Differential D2577

Update various scripts to use the new .format() method
ClosedPublic
Actions

Authored by Fabien on Feb 19 2019, 16:57.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGafa8e0234589: Update various scripts to use the new .format() method
rABCafa8e0234589: Update various scripts to use the new .format() method

Summary

Avoid using % to format strings, switch to the new method instead.

Test Plan

./test/functional/test_runner.py wallet_listsinceblock

./test/util/bitcoin-util-test.py

cd share
./qt/extract_strings_qt.py ../src/qt/splashscreen.cpp

Check that a file named qt/bitcoinstrings.cpp is outputted and its
content is correct.

./src/bitcoind -testnet -zmqpubrawtx=tcp://127.0.0.1:28332
-zmqpubrawblock=tcp://127.0.0.1:28332
-zmqpubhashtx=tcp://127.0.0.1:28332
-zmqpubhashblock=tcp://127.0.0.1:28332 &
./contrib/zmq/zmq_sub27.py

Should display a lot of data. Press CTRL+C when you get bored.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 19 2019, 16:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2019, 16:57

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5028: Diff 7396.Feb 19 2019, 17:12

deadalnix accepted this revision.Feb 19 2019, 19:38

This revision is now accepted and ready to land.Feb 19 2019, 19:38

Closed by commit rABCafa8e0234589: Update various scripts to use the new .format() method (authored by Fabien). · Explain WhyFeb 19 2019, 20:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGafa8e0234589: Update various scripts to use the new .format() method.Sep 18 2019, 22:28

Revision Contents
Changeset List

Path

Size

contrib/

zmq/

2 lines

share/

qt/

extract_strings_qt.py

13 lines

test/

functional/

combine_logs.py

7 lines

42 lines

wallet_listsinceblock.py

2 lines

util/

bitcoin-util-test.py

10 lines

Diff 7415

contrib/zmq/zmq_sub27.py

Loading...

share/qt/extract_strings_qt.py

Loading...

test/functional/combine_logs.py

Loading...

test/functional/test_runner.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...

test/util/bitcoin-util-test.py

Loading...