Page MenuHomePhabricator

[secp256k1] add ec_pubkey_parse to jni api
Needs RevisionPublic

Authored by floreslorca on Mar 26 2019, 02:25.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

implement parse pubkey

Test Plan

run testParsePubkey

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parse
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5301
Build 8664: Bitcoin ABC Teamcity Staging
Build 8663: arc lint + arc unit

Event Timeline

floreslorca created this revision.Mar 26 2019, 02:25
Owners added a reviewer: Restricted Owners Package.Mar 26 2019, 02:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2019, 02:25
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Mar 27 2019, 01:26
deadalnix added inline comments.
src/secp256k1/src/java/org/bitcoin/NativeSecp256k1.java
364

Why is that an ECDSA buffer?

src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java
179

There are no test cases for failures scenarii in parsePubKey

This revision now requires changes to proceed.Mar 27 2019, 01:26