Page MenuHomePhabricator

Add additional test in segwit recovery activation
ClosedPublic

Authored by florian on Wed, Apr 10, 22:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5e3527194d8a: Add additional test in segwit recovery activation
Summary

Add a new test case to ensure nodes won't ban each other before and after activation.

Test Plan

./test_runner abc-segwit-recovery-activation.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

florian created this revision.Wed, Apr 10, 22:48
Owners added a reviewer: Restricted Owners Package.Wed, Apr 10, 22:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 10, 22:48
florian added inline comments.Wed, Apr 10, 22:53
test/functional/abc-segwit-recovery-activation.py
341 ↗(On Diff #8029)

I moved this check before the sendrawtransaction call to avoid a race condition. The previous version could fail if node_nonstd, after sendrawtransaction, sent the segwit spending txn to node_std *before* we did this check. In this case, the transaction would be included in recentRejects and node_std would never send the REJECT message back to the mininode.

deadalnix requested changes to this revision.Wed, Apr 10, 22:57

The purpose of this test is to test activation. This isn't the right place for test vectors.

This revision now requires changes to proceed.Wed, Apr 10, 22:57
deadalnix accepted this revision.Wed, Apr 10, 23:18

OK the goal is to check for bans when the error is EVAL_FALSE.

This revision is now accepted and ready to land.Wed, Apr 10, 23:18
This revision was automatically updated to reflect the committed changes.