Page MenuHomePhabricator

Add additional test in segwit recovery activation

Authored by florian on Apr 10 2019, 22:48.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
rABC5e3527194d8a: Add additional test in segwit recovery activation

Add a new test case to ensure nodes won't ban each other before and after activation.

Test Plan


Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

florian created this revision.Apr 10 2019, 22:48
Owners added a reviewer: Restricted Owners Package.Apr 10 2019, 22:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2019, 22:48
florian added inline comments.Apr 10 2019, 22:53
341 ↗(On Diff #8029)

I moved this check before the sendrawtransaction call to avoid a race condition. The previous version could fail if node_nonstd, after sendrawtransaction, sent the segwit spending txn to node_std *before* we did this check. In this case, the transaction would be included in recentRejects and node_std would never send the REJECT message back to the mininode.

deadalnix requested changes to this revision.Apr 10 2019, 22:57

The purpose of this test is to test activation. This isn't the right place for test vectors.

This revision now requires changes to proceed.Apr 10 2019, 22:57
deadalnix accepted this revision.Apr 10 2019, 23:18

OK the goal is to check for bans when the error is EVAL_FALSE.

This revision is now accepted and ready to land.Apr 10 2019, 23:18
This revision was automatically updated to reflect the committed changes.