Page MenuHomePhabricator
Differential D2804

Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist"
ClosedPublic
Actions

Authored by deadalnix on Apr 15 2019, 13:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist"
rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist"
Summary

This reverts commit f00d08b715e911a68dcc14cb6eb6f77bdaf48acf.

It's 80% of arc lint run time.

Test Plan

Run arc lint . Verify it is now 5 time faster.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lintlocalerevert
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5456
Build 8974: Bitcoin ABC Buildbot (legacy)
Build 8973: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 15 2019, 13:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2019, 13:04
teamcity added a comment.Apr 15 2019, 13:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 15 2019, 13:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5456: Diff 8056.Apr 15 2019, 13:19
Fabien accepted this revision.Apr 15 2019, 14:02
Fabien added a subscriber: Fabien.

I will search for the cause of the performance issue and re-enable it when it gets fixed

This revision is now accepted and ready to land.Apr 15 2019, 14:02
Closed by commit rABC6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist" (authored by deadalnix). · Explain WhyApr 15 2019, 14:13
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2880: [LINTER] Revive the locale dependent functions linter in arcanist.Apr 26 2019, 13:14
Fabien mentioned this in rABCf01b98dc111d: [LINTER] Revive the locale dependent functions linter in arcanist.May 7 2019, 11:29
deadalnix added a commit: rSTAGING6cd6a3ee3d67: Revert "[LINTER] Integrate lint-locale-dependence.sh into arcanist".Sep 18 2019, 22:57
Fabien mentioned this in rSTAGINGf01b98dc111d: [LINTER] Revive the locale dependent functions linter in arcanist.Sep 18 2019, 23:18

Revision Contents
Changeset List

Diff 8056

View Options

.arclint

Loading...
View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/LocalDependenceLinter.php

Loading...
View Options

test/lint/lint-locale-dependence.sh

Loading...