Page MenuHomePhabricator

Use angle bracket in include for tests (part 1)
ClosedPublic

Authored by Fabien on Apr 19 2019, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABCa8a53a7b5169: Use angle bracket in include for tests (part 1)
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Apr 19 2019, 09:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2019, 09:42
deadalnix requested changes to this revision.Apr 19 2019, 12:46
deadalnix added inline comments.
src/test/addrman_tests.cpp
7 ↗(On Diff #8140)

Put system library after local ones.

This revision now requires changes to proceed.Apr 19 2019, 12:46
Fabien updated this revision to Diff 8143.Apr 19 2019, 12:52

System library included last

deadalnix requested changes to this revision.Apr 19 2019, 14:35
deadalnix added inline comments.
src/test/addrman_tests.cpp
6 ↗(On Diff #8143)

Ok this is not in the excepted order? Please look at how other test order includes. because include are copy pasted, this is important.

This revision now requires changes to proceed.Apr 19 2019, 14:35
Fabien updated this revision to Diff 8147.Apr 19 2019, 15:20

Attempt to make the include order consistent in tests

deadalnix accepted this revision.Apr 19 2019, 16:54
This revision is now accepted and ready to land.Apr 19 2019, 16:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: Restricted Diffusion Commit.Wed, Sep 18, 23:04