Use angle bracket in include for tests (part 1)
ClosedPublic
Actions

Authored by Fabien on Apr 19 2019, 09:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa8a53a7b5169: Use angle bracket in include for tests (part 1)
rABCa8a53a7b5169: Use angle bracket in include for tests (part 1)

Summary

As per title

Partial backport of PR11651

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11651_part16

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5523
Build 9108: Bitcoin ABC Buildbot (legacy)
Build 9107: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 19 2019, 09:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 19 2019, 09:42

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5521: Diff 8140.Apr 19 2019, 09:56

deadalnix requested changes to this revision.Apr 19 2019, 12:46

deadalnix added inline comments.

src/test/addrman_tests.cpp
7 ↗	(On Diff #8140)	Put system library after local ones.

This revision now requires changes to proceed.Apr 19 2019, 12:46

System library included last

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5523: Diff 8143.Apr 19 2019, 13:07

deadalnix requested changes to this revision.Apr 19 2019, 14:35

deadalnix added inline comments.

src/test/addrman_tests.cpp
6	Ok this is not in the excepted order? Please look at how other test order includes. because include are copy pasted, this is important.

This revision now requires changes to proceed.Apr 19 2019, 14:35

Attempt to make the include order consistent in tests

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5524: Diff 8147.Apr 19 2019, 15:34

deadalnix accepted this revision.Apr 19 2019, 16:54

This revision is now accepted and ready to land.Apr 19 2019, 16:54

Closed by commit rABCa8a53a7b5169: Use angle bracket in include for tests (part 1) (authored by Fabien). · Explain WhyApr 19 2019, 20:14

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48

Fabien added a commit: rSTAGINGa8a53a7b5169: Use angle bracket in include for tests (part 1).Sep 18 2019, 23:04

Revision Contents
Changeset List

Path

Size

src/

test/

24 lines

10 lines

13 lines

6 lines

4 lines

arith_uint256_tests.cpp

8 lines

8 lines

4 lines

22 lines

4 lines

12 lines

12 lines

blockencodings_tests.cpp

12 lines

blockindex_tests.cpp

10 lines

blockstatus_tests.cpp

6 lines

bloom_tests.cpp

26 lines

bswap_tests.cpp

4 lines

cashaddr_tests.cpp

4 lines

cashaddrenc_tests.cpp

12 lines

checkdatasig_tests.cpp

8 lines

Diff 8143

View Options

src/test/DoS_tests.cpp

View Options

src/test/activation_tests.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/allocator_tests.cpp

View Options

src/test/amount_tests.cpp

View Options

src/test/arith_uint256_tests.cpp

View Options

src/test/avalanche_tests.cpp

View Options

src/test/base32_tests.cpp

View Options

src/test/base58_tests.cpp

View Options

src/test/base64_tests.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/blockindex_tests.cpp

View Options

src/test/blockstatus_tests.cpp

View Options

src/test/bloom_tests.cpp

View Options

src/test/bswap_tests.cpp

View Options

src/test/cashaddr_tests.cpp

View Options

src/test/cashaddrenc_tests.cpp

View Options

src/test/checkdatasig_tests.cpp

Use angle bracket in include for tests (part 1)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8143

src/test/DoS_tests.cpp

src/test/activation_tests.cpp

src/test/addrman_tests.cpp

src/test/allocator_tests.cpp

src/test/amount_tests.cpp

src/test/arith_uint256_tests.cpp

src/test/avalanche_tests.cpp

src/test/base32_tests.cpp

src/test/base58_tests.cpp

src/test/base64_tests.cpp

src/test/bip32_tests.cpp

src/test/blockcheck_tests.cpp

src/test/blockencodings_tests.cpp

src/test/blockindex_tests.cpp

src/test/blockstatus_tests.cpp

src/test/bloom_tests.cpp

src/test/bswap_tests.cpp

src/test/cashaddr_tests.cpp

src/test/cashaddrenc_tests.cpp

src/test/checkdatasig_tests.cpp

Use angle bracket in include for tests (part 1)
ClosedPublic
Actions

Revision Contents
Changeset List