Page MenuHomePhabricator

Use angle bracket in include for tests (part 1)
ClosedPublic

Authored by Fabien on Apr 19 2019, 09:42.

Details

Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part16
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5523
Build 9108: Bitcoin ABC Buildbot (legacy)
Build 9107: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Apr 19 2019, 12:46
deadalnix added inline comments.
src/test/addrman_tests.cpp
7 ↗(On Diff #8140)

Put system library after local ones.

This revision now requires changes to proceed.Apr 19 2019, 12:46

System library included last

deadalnix requested changes to this revision.Apr 19 2019, 14:35
deadalnix added inline comments.
src/test/addrman_tests.cpp
6

Ok this is not in the excepted order? Please look at how other test order includes. because include are copy pasted, this is important.

This revision now requires changes to proceed.Apr 19 2019, 14:35

Attempt to make the include order consistent in tests

This revision is now accepted and ready to land.Apr 19 2019, 16:54
This revision was automatically updated to reflect the committed changes.