Use angle bracket in include for qt dialog files
ClosedPublic
Actions

Authored by Fabien on May 3 2019, 08:52.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGd65e93b70a69: Use angle bracket in include for qt dialog files
rABCd65e93b70a69: Use angle bracket in include for qt dialog files

Summary

As per title

Partial backport of PR11651

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 3 2019, 08:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 3 2019, 08:52

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5657: Diff 8355.May 3 2019, 09:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 3 2019, 16:51

This revision is now accepted and ready to land.May 3 2019, 16:51

Closed by commit rABCd65e93b70a69: Use angle bracket in include for qt dialog files (authored by Fabien). · Explain WhyMay 3 2019, 18:52

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48

Fabien added a commit: rSTAGINGd65e93b70a69: Use angle bracket in include for qt dialog files.Sep 18 2019, 23:13

Revision Contents
Changeset List

Path

Size

src/

qt/

askpassphrasedialog.cpp

13 lines

coincontroldialog.h

2 lines

editaddressdialog.cpp

8 lines

openuridialog.cpp

8 lines

receivecoinsdialog.h

2 lines

receivecoinsdialog.cpp

24 lines

receiverequestdialog.h

2 lines

receiverequestdialog.cpp

18 lines

signverifymessagedialog.cpp

25 lines

transactiondescdialog.cpp

6 lines

utilitydialog.cpp

32 lines

Diff 8368

View Options

src/qt/askpassphrasedialog.cpp

View Options

src/qt/coincontroldialog.h

View Options

src/qt/editaddressdialog.cpp

View Options

src/qt/openuridialog.cpp

View Options

src/qt/receivecoinsdialog.h

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/receiverequestdialog.h

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/transactiondescdialog.cpp

View Options

Use angle bracket in include for qt dialog filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8368

src/qt/askpassphrasedialog.cpp

src/qt/coincontroldialog.h

src/qt/editaddressdialog.cpp

src/qt/openuridialog.cpp

src/qt/receivecoinsdialog.h

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.h

src/qt/receiverequestdialog.cpp

src/qt/signverifymessagedialog.cpp

src/qt/transactiondescdialog.cpp

src/qt/utilitydialog.cpp

Use angle bracket in include for qt dialog files
ClosedPublic
Actions

Revision Contents
Changeset List