Differential D2925

test: Stop txindex thread before calling destructor
AbandonedPublic
Actions

Authored by markblundeberg on Sun, May 5, 01:37.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T617: Backport PR 13033 "Build txindex in parallel with validation"

Summary

backports PR14071:
faf4a9b674 qa: Stop txindex thread before calling destructor (MarcoFalke)
and PR15410:
fab6b07c16 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)

Depends on D2924

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txindextest_fix

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 5675
Build 9412: Bitcoin ABC Teamcity Staging
Build 9411: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Sun, May 5, 01:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, May 5, 01:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T617: Backport PR 13033 "Build txindex in parallel with validation".Sun, May 5, 01:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5675: Diff 8390.Sun, May 5, 01:52

markblundeberg edited the summary of this revision. (Show Details)Sun, May 5, 17:08

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

This revision now requires changes to proceed.Sun, May 5, 21:44

In D2925#69387, @deadalnix wrote:

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

Aye aye, cap'n.

markblundeberg mentioned this in D2924: [WIP] [txindex] Activate new transaction index code that runs in background.Sun, May 5, 21:55

Revision Contents
Changeset List

			Path	Packages
M			src/test/txindex_tests.cpp (8 lines)

Commit	Tree	Parents	Author	Summary	Date
ae4a0d1420b7	a9e355f559d4	4ff046c4124a	MarcoFalke	test: Stop txindex thread before calling destructor (Show More…)	Aug 26 2018, 14:18

Status	Author	Revision
Closed	markblundeberg	D2928 Simplify semantics of ChainStateFlushed callback
Closed	markblundeberg	D2927 scripted-diff: Rename SetBestChain callback ChainStateFlushed
Needs Review	markblundeberg	D2938 index: Move index DBs into index/ directory.
Needs Review	markblundeberg	D2937 MOVEONLY: Move BaseIndex to its own file.
Needs Review	markblundeberg	D2936 index: Generalize logged statements in BaseIndex.
Needs Review	markblundeberg	D2935 index: Extract logic from TxIndex into reusable base class.
Needs Review	markblundeberg	D2934 db: Make reusable base class for index databases.
Accepted	markblundeberg	D2933 db: Remove obsolete methods from CBlockTreeDB.
Closed	markblundeberg	D2932 Support serialization as another type without casting
Closed	markblundeberg	D2931 Support deserializing into temporaries
Closed	markblundeberg	D2930 Merge READWRITEMANY into READWRITE
Closed	markblundeberg	D2929 Sanitize some wallet serialization
Abandoned	markblundeberg	D2925 test: Stop txindex thread before calling destructor
Changes Planned	markblundeberg	D2924 [WIP] [txindex] Activate new transaction index code that runs in background
Closed	markblundeberg	D2904 [index] Create new TxIndex class.
Closed	markblundeberg	D2903 [db] Migration for txindex data to new, separate database.
Closed	markblundeberg	D2901 [db] Create separate database for txindex.

Diff 8390

View Options

src/test/txindex_tests.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8390	4ff046c		Sun, May 5, 01:37	★	★

test: Stop txindex thread before calling destructorAbandonedPublicActions