Page MenuHomePhabricator

test: Stop txindex thread before calling destructor
AbandonedPublic

Authored by markblundeberg on Sun, May 5, 01:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T617: Backport PR 13033 "Build txindex in parallel with validation"
Summary

backports PR14071:
faf4a9b674 qa: Stop txindex thread before calling destructor (MarcoFalke)
and PR15410:
fab6b07c16 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)

Depends on D2924

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txindextest_fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5675
Build 9412: Bitcoin ABC Teamcity Staging
Build 9411: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Sun, May 5, 01:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, May 5, 01:37
markblundeberg edited the summary of this revision. (Show Details)Sun, May 5, 17:08
deadalnix requested changes to this revision.Sun, May 5, 21:44

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

This revision now requires changes to proceed.Sun, May 5, 21:44
markblundeberg abandoned this revision.Sun, May 5, 21:50

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

Aye aye, cap'n.