Page MenuHomePhabricator
Differential D2925

test: Stop txindex thread before calling destructor
AbandonedPublic
Actions

Authored by markblundeberg on May 5 2019, 01:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T617: Backport PR 13033 "Build txindex in parallel with validation"
Summary

backports PR14071:
faf4a9b674 qa: Stop txindex thread before calling destructor (MarcoFalke)
and PR15410:
fab6b07c16 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)

Depends on D2924

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txindextest_fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5675
Build 9412: Bitcoin ABC Buildbot (legacy)
Build 9411: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 01:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 01:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 5 2019, 01:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T617: Backport PR 13033 "Build txindex in parallel with validation".May 5 2019, 01:44
teamcity added a comment.May 5 2019, 01:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5675: Diff 8390.May 5 2019, 01:52
markblundeberg edited the summary of this revision. (Show Details)May 5 2019, 17:08
deadalnix requested changes to this revision.May 5 2019, 21:44

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

This revision now requires changes to proceed.May 5 2019, 21:44
markblundeberg abandoned this revision.May 5 2019, 21:50
In D2925#69387, @deadalnix wrote:

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

Aye aye, cap'n.

markblundeberg mentioned this in D2924: [txindex] Activate new transaction index code that runs in background.May 5 2019, 21:55

Revision Contents
Changeset List

PathSize
src/
test/
8 lines

Diff 8390

View Options

src/test/txindex_tests.cpp

Loading...