Page MenuHomePhabricator

test: Stop txindex thread before calling destructor
AbandonedPublic

Authored by markblundeberg on May 5 2019, 01:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T617: Backport PR 13033 "Build txindex in parallel with validation"
Summary

backports PR14071:
faf4a9b674 qa: Stop txindex thread before calling destructor (MarcoFalke)
and PR15410:
fab6b07c16 test: txindex: interrupt threadGroup before calling destructor (MarcoFalke)

Depends on D2924

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
txindextest_fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5675
Build 9412: Bitcoin ABC Teamcity Staging
Build 9411: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 5 2019, 01:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2019, 01:37
markblundeberg edited the summary of this revision. (Show Details)May 5 2019, 17:08
deadalnix requested changes to this revision.May 5 2019, 21:44

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

This revision now requires changes to proceed.May 5 2019, 21:44
markblundeberg abandoned this revision.May 5 2019, 21:50

Please merge that with the test and the creation go TxIndex. We do not benefit from commiting faulty code and then fixing it.

Aye aye, cap'n.