Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()
ClosedPublic
Actions

Authored by jasonbcox on May 6 2019, 21:16.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING0c835225f245: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()
rABC0c835225f245: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()

Summary

a56f8b0 Add missing lock in CScheduler::AreThreadsServicingQueue() (Matt Corallo)

Pull request description:

Not an actual bug as this is only used in asserts right now, but
nice to not have a missing lock.

Tree-SHA512: 7e542b150a0be716783e196493d239f2ad15e5376abf54b67d735dc3ef1b10849c090337b849f530c9f7497ddcfb8389b47d64a5dcf6382b7d38838f88cc1100

Backport of Core PR 10914
https://github.com/bitcoin/bitcoin/pull/10914/files

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 6 2019, 21:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 21:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5701: Diff 8425.May 6 2019, 21:31

Fabien accepted this revision.May 7 2019, 05:44

This revision is now accepted and ready to land.May 7 2019, 05:44

Closed by commit rABC0c835225f245: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 7 2019, 15:21

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING0c835225f245: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue().Sep 18 2019, 23:19

Revision Contents
Changeset List

Path

Size

src/

scheduler.cpp

1 line

Diff 8466

View Options

Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()ClosedPublicActions