[CMAKE] Add an option to reduce exports
ClosedPublic
Actions

Authored by Fabien on May 7 2019, 12:04.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING8808e31743fb: [CMAKE] Add an option to reduce exports
rABC8808e31743fb: [CMAKE] Add an option to reduce exports

Summary

Port of configure option --enable-reduce-exports.
This tries to reduce the amount of symbols which are exported in the
application binary.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -DENABLE_REDUCE_EXPORTS=OFF -GNinja ..
ninja
../contrib/devtools/symbol-check.py src/bitcoind | wc -l

Note the output of the last command.

rm -rf *
cmake -DENABLE_REDUCE_EXPORTS=ON -GNinja ..
ninja
../contrib/devtools/symbol-check.py src/bitcoind | wc -l

The quantity of line should be greatly reduced (244 => 123 on my
machine)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 7 2019, 12:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 12:04

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5725: Diff 8455.May 7 2019, 12:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 8 2019, 21:28

This revision is now accepted and ready to land.May 8 2019, 21:28

Closed by commit rABC8808e31743fb: [CMAKE] Add an option to reduce exports (authored by Fabien). · Explain WhyMay 10 2019, 10:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING8808e31743fb: [CMAKE] Add an option to reduce exports.Sep 18 2019, 23:28

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

15 lines

Diff 8587

View Options

[CMAKE] Add an option to reduce exportsClosedPublicActions