Page MenuHomePhabricator

[docs] Reformat -help output for help2man
ClosedPublic

Authored by deadalnix on May 14 2019, 17:15.

Details

Summary

This commit slightly changes the format of the "Usage" strings in CLI
-help messages to meet the expection of the help2man tool, which we
use to generate man pages. On the way, we remove a few calls to
strprintf(), which became superficial after commit 32fbfda.

This is a backport of Core PR13872

Test Plan
make check
BUILDDIR=~/bitcoin-abc/build ../contrib/devtools/gen-manpages.sh

Make sure the new generated manpages do make sense.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
helpformat
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5870
Build 9800: Bitcoin ABC Teamcity Staging
Build 9799: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 14 2019, 17:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 17:15
Fabien requested changes to this revision.May 16 2019, 13:31
Fabien added a subscriber: Fabien.

The test plan should include -help and man pages check

This revision now requires changes to proceed.May 16 2019, 13:31
deadalnix requested review of this revision.May 16 2019, 15:46
deadalnix edited the test plan for this revision. (Show Details)

Updated test plan

deadalnix edited the test plan for this revision. (Show Details)May 16 2019, 15:47
Fabien accepted this revision.May 16 2019, 16:15
This revision is now accepted and ready to land.May 16 2019, 16:15
This revision was automatically updated to reflect the committed changes.